Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Paul Cercueil <paul@crapouillou.net>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Cristian Birsan <cristian.birsan@microchip.com>,
        Felipe Balbi <balbi@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        Avi Fishman <avifishman70@gmail.com>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Tony Prisk <linux@prisktech.co.nz>, Bin Liu <b-liu@ti.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH 14/20] usb/phy: mxs-usb: Use pm_ptr() macro
Thread-Topic: [PATCH 14/20] usb/phy: mxs-usb: Use pm_ptr() macro
Thread-Index: AQHWgeU+2b62vIVikUSNVdUVtDfvy6lZLW4A
Date:   Sat, 5 Sep 2020 00:08:20 +0000
Message-ID: <20200905000758.GB24243@b29397-desktop>
References: <20200903112554.34263-1-paul@crapouillou.net>
 <20200903112554.34263-15-paul@crapouillou.net>
In-Reply-To: <20200903112554.34263-15-paul@crapouillou.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5F23AC27CA69B84BAEF6DA2F1CA676FE@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 96288c73-4a0b-465f-ae64-08d8512fcc9f
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2020 00:08:20.8855
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t/T+7exD5w8dbf3ThBeDiU5yLFkkmIugiBMguAu1qf7AmBNeU4pWCBuoP29IfSUKF8AcB/7yxKqWipmsXrXIww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5605
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-09-03 13:25:48, Paul Cercueil wrote:
> Use the newly introduced pm_ptr() macro, and mark the suspend/resume
> functions __maybe_unused. These functions can then be moved outside the
> CONFIG_PM_SUSPEND block, and the compiler can then process them and
> detect build failures independently of the config. If unused, they will
> simply be discarded by the compiler.
>=20
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/usb/phy/phy-mxs-usb.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.=
c
> index 67b39dc62b37..c5e32d51563f 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -815,8 +815,8 @@ static int mxs_phy_remove(struct platform_device *pde=
v)
>  	return 0;
>  }
> =20
> -#ifdef CONFIG_PM_SLEEP
> -static void mxs_phy_enable_ldo_in_suspend(struct mxs_phy *mxs_phy, bool =
on)
> +static void __maybe_unused
> +mxs_phy_enable_ldo_in_suspend(struct mxs_phy *mxs_phy, bool on)
>  {
>  	unsigned int reg =3D on ? ANADIG_ANA_MISC0_SET : ANADIG_ANA_MISC0_CLR;
> =20
> @@ -832,7 +832,7 @@ static void mxs_phy_enable_ldo_in_suspend(struct mxs_=
phy *mxs_phy, bool on)
>  			reg, BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG_SL);
>  }
> =20
> -static int mxs_phy_system_suspend(struct device *dev)
> +static int __maybe_unused mxs_phy_system_suspend(struct device *dev)
>  {
>  	struct mxs_phy *mxs_phy =3D dev_get_drvdata(dev);
> =20
> @@ -842,7 +842,7 @@ static int mxs_phy_system_suspend(struct device *dev)
>  	return 0;
>  }
> =20
> -static int mxs_phy_system_resume(struct device *dev)
> +static int __maybe_unused mxs_phy_system_resume(struct device *dev)
>  {
>  	struct mxs_phy *mxs_phy =3D dev_get_drvdata(dev);
> =20
> @@ -851,7 +851,6 @@ static int mxs_phy_system_resume(struct device *dev)
> =20
>  	return 0;
>  }
> -#endif /* CONFIG_PM_SLEEP */
> =20
>  static SIMPLE_DEV_PM_OPS(mxs_phy_pm, mxs_phy_system_suspend,
>  		mxs_phy_system_resume);
> @@ -862,7 +861,7 @@ static struct platform_driver mxs_phy_driver =3D {
>  	.driver =3D {
>  		.name =3D DRIVER_NAME,
>  		.of_match_table =3D mxs_phy_dt_ids,
> -		.pm =3D &mxs_phy_pm,
> +		.pm =3D pm_ptr(&mxs_phy_pm),
>  	 },
>  };
> =20
> --=20

Acked-by: Peter Chen <peter.chen@nxp.com>

--=20

Thanks,
Peter Chen=