Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200904180647.21080-1-trix@redhat.com>
In-Reply-To: <20200904180647.21080-1-trix@redhat.com>
From:   Elie Morisse <syniurge@gmail.com>
Date:   Sat, 5 Sep 2020 14:33:47 +0200
Message-ID: <CAC_JBqor9K07a_ok35QOtd-CxYjpUu=915+HNcvYmnfunt2-Mw@mail.gmail.com>
Subject: Re: [PATCH] i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer
To:     trix@redhat.com
Cc:     "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>,
        Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
        natechancellor@gmail.com, ndesaulniers@google.com,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        clang-built-linux@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Acked-by: Elie Morisse <syniurge@gmail.com>

Le ven. 4 sept. 2020 =C3=A0 20:06, <trix@redhat.com> a =C3=A9crit :
>
> From: Tom Rix <trix@redhat.com>
>
> clang static analyzer reports this problem
>
> i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates
>   to a garbage value
>         return err ? err : num;
>                ^~~
>
> err is not initialized, it depends on the being set in the
> transfer loop which will not happen if num is 0.  Surveying
> other master_xfer() implementations show all handle a 0 num.
>
> Because returning 0 is expected, initialize err to 0.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/i2c/busses/i2c-amd-mp2-plat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-amd-mp2-plat.c b/drivers/i2c/busses/i=
2c-amd-mp2-plat.c
> index 17df9e8845b6..506433bc0ff2 100644
> --- a/drivers/i2c/busses/i2c-amd-mp2-plat.c
> +++ b/drivers/i2c/busses/i2c-amd-mp2-plat.c
> @@ -155,7 +155,7 @@ static int i2c_amd_xfer(struct i2c_adapter *adap, str=
uct i2c_msg *msgs, int num)
>         struct amd_i2c_dev *i2c_dev =3D i2c_get_adapdata(adap);
>         int i;
>         struct i2c_msg *pmsg;
> -       int err;
> +       int err =3D 0;
>
>         /* the adapter might have been deleted while waiting for the bus =
lock */
>         if (unlikely(!i2c_dev->common.mp2_dev))
> --
> 2.18.1
>