Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/1] Input: atmel_mxt_ts - implement I2C retries
To:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Jiada Wang <jiada_wang@mentor.com>
Cc:     "nick@shmanahar.org" <nick@shmanahar.org>,
        "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Andrew_Gabbasov@mentor.com" <Andrew_Gabbasov@mentor.com>,
        "erosca@de.adit-jv.com" <erosca@de.adit-jv.com>
References: <20200903155904.17454-1-jiada_wang@mentor.com>
 <CAHp75Vfw1bJ+0pRJKVJ=nCJ-5rVzYLjkP4iWPqiG-it0qp5GFg@mail.gmail.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <610b2513-7d62-386d-ed2a-54e1bea4df43@gmail.com>
Date:   Sat, 5 Sep 2020 21:57:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAHp75Vfw1bJ+0pRJKVJ=nCJ-5rVzYLjkP4iWPqiG-it0qp5GFg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

05.09.2020 21:02, Andy Shevchenko пишет:
...
>      #define MXT_CRC_TIMEOUT                1000    /* msec */
>      #define MXT_FW_RESET_TIME      3000    /* msec */
>      #define MXT_FW_CHG_TIMEOUT     300     /* msec */
>     +#define MXT_WAKEUP_TIME                25      /* msec */
> 
> 
> Can we simple add _MS unit suffix to the definition?

I'd expect this

>      /* Command to unlock bootloader */
>      #define MXT_UNLOCK_CMD_MSB     0xaa
>     @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client,
>             struct i2c_msg xfer[2];
>             u8 buf[2];
>             int ret;
>     +       bool retry = false;
> 
> 
> Keep this ordered by length.

and this to be separate patches that are cleaning whole driver code,
otherwise there are no much benefits.