Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2294043pxk; Sat, 5 Sep 2020 16:38:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjcFTeXh45CW9jsMKc6k35DCW9m4Di69YHSnRRPKZaipP5oh6OM5BIm+jPV5upng212gv9 X-Received: by 2002:a17:906:2b87:: with SMTP id m7mr14294812ejg.210.1599349130447; Sat, 05 Sep 2020 16:38:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599349130; cv=none; d=google.com; s=arc-20160816; b=fNtk+PwZFpkLiT8q+HgOaf3LEhjbAPN6SJvZAHVYq4uvYpnA30XubfQokNSAYlTqXr 4o9XPu7Jp2cg+ZvPSkith8FKADE6WNsirJynVGMdYR5cJZl/jcHDWgyJrrO3pnwwgioT Qfjl14nj1qgzilzuv3pxrw7JgcVBTnuhxxKkkZ4xyn9XpFl88opE8GKfOw8qhlj3DfKS cQriBVgG2PpTnFfNnA/LbdTdQ8RzJnStY+u0bsCaKhuejbK/wbdYyVA6upH1rZBX2nua lxgVJ8l5c2JfiGEBIrSBuhArHHmn7FpSOrCNtlhsJrhaQb9q+gbWu5zTyK+BvGyd7b8h AxGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=MDjX99RSQ6WV2AYeVqKa+jaUbGTlOPOUsbIFD+XW/Eo=; b=qSSitWlX/bVp4rpxaiQJuoqqBpVV09wQYuei9bhEuqQQdCEAT9c/Y5nOzX5O7t6KZM 4LF/gGI/d/oQRSw/djihA6VBMzXTd386fLIZ7bIOrXos2ASTQ1Ht2b23vvC3VUuzhbxZ wpSq0nvgNTSh5OCBm1+BiwYE5XGkFZ1V5+frblS99RCOacj31mf/tWjDaaLEqCK4KAeU fdrFOU7dgInPmY6YVbFABEqbxS4r3RjiOk+CSbZ6tkA/6hX/1W3lmxyVQgoutZFK6Hft 3HzxZVJCUzQb8jjK+GWR1DO+qHhR2OtPXiG6jI8YZpL94bNxyxTPO2z27xoN9Olj9XSr hXyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fj9AGwiR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s24si7261964ejd.131.2020.09.05.16.38.27; Sat, 05 Sep 2020 16:38:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fj9AGwiR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728867AbgIEXhK (ORCPT + 99 others); Sat, 5 Sep 2020 19:37:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:52626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728103AbgIEXhJ (ORCPT ); Sat, 5 Sep 2020 19:37:09 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9DDAF20760; Sat, 5 Sep 2020 23:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599349029; bh=rpeS5XHUij27LdjfSXTm57hB+BZoxEGDguTEGPPB1XY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fj9AGwiRHUE4yk+KXhFmB7MuGeJ+yfwxEs9krALrdFd4z9ZKrxI0PT0F4w0rslDxS gbsrnSN4Ln61IQLrCV54Zb5BjSyKCV4zsvP4YD8x81rLVcdNTit0lornd8uUS2w0+i E2AP8cR6ir1bgoY37X/fOh4Kyf/7cfdOP2P+jmDY= Date: Sat, 5 Sep 2020 16:37:06 -0700 From: Jakub Kicinski To: Landen Chao Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Rob Herring , Matthias Brugger , Sean Wang , Philipp Zabel , Russell King , , , , , , , , Subject: Re: [PATCH net-next v3 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531 Message-ID: <20200905163706.60cdceb5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <4ec3c9e6a219c09fc90d1be8d3d63da587ef6fba.1599228079.git.landen.chao@mediatek.com> References: <4ec3c9e6a219c09fc90d1be8d3d63da587ef6fba.1599228079.git.landen.chao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Sep 2020 22:21:58 +0800 Landen Chao wrote: > @@ -32,10 +33,13 @@ Required properties for the child nodes within ports container: > > - reg: Port address described must be 6 for CPU port and from 0 to 5 for > user ports. > -- phy-mode: String, must be either "trgmii" or "rgmii" for port labeled > - "cpu". > +- phy-mode: String, the follow value would be acceptable for port labeled "cpu" ... the following values are acceptable for port labeled "cpu": > + If compatible mediatek,mt7530 or mediatek,mt7621 is set, > + must be either "trgmii" or "rgmii" > + If compatible mediatek,mt7531 is set, > + must be either "sgmii", "1000base-x" or "2500base-x"