Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2298723pxk; Sat, 5 Sep 2020 16:51:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdtxilt0ZPMDL6e/Kknb+9EHs40C0uAUBpzyHAhVITZ+lnIIHlXbxq6P9lbq21MxPrheri X-Received: by 2002:a05:6402:1b9a:: with SMTP id cc26mr15030259edb.30.1599349910514; Sat, 05 Sep 2020 16:51:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599349910; cv=none; d=google.com; s=arc-20160816; b=my279w5Lm+7wmjZChJj6fgD11Qy79k5Ruc/MgV3yS0QauWg5d+UNFUuE55KFZLPsyt dVP0qD/JksLUBBBIEb+SlB7ySidEhXnTDs5lGIKC45OQG3rP7GGVjcgPvkx2eb85RuOY p61q5BfH3cdOZt73lpHVOv23GQAEiPanKvz96Z3YmS43qZVtbs+Ublmh1SNHHlyYlndP 9Gbw2lgrVyEbaxG8cQ86xhWdIeQbd0D6tBjHH9xE8wYKzTOW7/yb0f0xp8qpWjzpiNSv NUKs1JcKwNrsQmgjrphQ0+pn179ZZ+glC+/+Fu2mUFiYas5AdsFUL2vZ//wduPd3QI9m LCRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=xIfdKToz0u7QKWJzVkX42O5EmXO5BUN77G5YYUx1b8g=; b=P0Ju+tgFzH34eiInlcWCi2D2BzKffxo7GMyWJ3DNN4hC8T3/qadlxWFeljPinzM1yQ JEn9FCR2tb6IW1JRC+BsylxK93nIgdi8If8h90ZsPqfE3ghfXMkTI0rfAgZAun7dcas9 2pwf5ekGe0eb/W3K9OIDxLhEs5snXZCEesqJIAVMXdtZoQvupXd2zGhzdzSqBxKoDbnY geDREYVHEMRvpUzU3IkknXX7sE3cwCxaToIK+UsTFVs/d3lIXyjHBqc4FhNJlTOcjmPF nl4ySenJBgq3IYcQorqmOh5aIgwpyiQ5yTLgwO9Ur8D4ROP+lB9g1sNGS3+9x287JgeX m1UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WcGkCr4t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q17si3874588eju.141.2020.09.05.16.51.27; Sat, 05 Sep 2020 16:51:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WcGkCr4t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbgIEXuw (ORCPT + 99 others); Sat, 5 Sep 2020 19:50:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:58478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728103AbgIEXuu (ORCPT ); Sat, 5 Sep 2020 19:50:50 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2411B2072D; Sat, 5 Sep 2020 23:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599349849; bh=h0R4sF+5A4qwm1j7RZDzVqY8zeUBVfqPznj/PjB+chg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WcGkCr4t1aHtiLM2bweaw/TvLg1ZWv+tDICD8sUu3E2m4RaqIarx2DnPeOjVa1urZ lDJcH+vYwCyDVzHZGwXi0NtftkjtgUuddnMa3y6xealnrlMs0fMdi7/EV6k9GQJLBm 81nAsgH8dEH01nbQBQpGx5PtLOpiXs1toeaMOg5Y= Date: Sat, 5 Sep 2020 16:50:47 -0700 From: Jakub Kicinski To: Landen Chao Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Rob Herring , Matthias Brugger , Sean Wang , Philipp Zabel , Russell King , , , , , , , , Subject: Re: [PATCH net-next v3 4/6] net: dsa: mt7530: Add the support of MT7531 switch Message-ID: <20200905165047.32f94ae5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <63041b5c2c346b874e92761b3b3d6553106dde98.1599228079.git.landen.chao@mediatek.com> References: <63041b5c2c346b874e92761b3b3d6553106dde98.1599228079.git.landen.chao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Sep 2020 22:21:59 +0800 Landen Chao wrote: > +static int > +mt7531_cpu_port_config(struct dsa_switch *ds, int port) > +{ > + struct mt7530_priv *priv = ds->priv; > + phy_interface_t interface; > + int speed; > + > + switch (port) { > + case 5: > + if (mt7531_is_rgmii_port(priv, port)) > + interface = PHY_INTERFACE_MODE_RGMII; > + else > + interface = PHY_INTERFACE_MODE_2500BASEX; > + > + priv->p5_interface = interface; > + break; > + case 6: > + interface = PHY_INTERFACE_MODE_2500BASEX; > + > + mt7531_pad_setup(ds, interface); > + > + priv->p6_interface = interface; > + break; > + }; stray semicolon