Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2352659pxk; Sat, 5 Sep 2020 19:21:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKZw/NPQrBoVax3pAs9+CxsmUAjbOmedBn0bBXUa8cJggX3awIXhPgSyB7ihQ91qxJRD0t X-Received: by 2002:a50:bb0d:: with SMTP id y13mr4818503ede.317.1599358912784; Sat, 05 Sep 2020 19:21:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599358912; cv=none; d=google.com; s=arc-20160816; b=LOEa5oGRB/Enfg+O8eu8U6BVFq8D6zw4Y+3pYmyRHyYnEbf+rve1xrh9H1ahJqfxKj aVxMabHsde3ncckk2PrwryrE3cnol0INaM3YMrIKWoETugw1tPg4JMzprZAXj/eC+c0A gMlIsamTQU+rwYtkM3xpDvPSm58olxi3L48iTwmiTJ7qVWgROKN2xKOAWKI3s7G6xzzD XGw/C/Cif43oRwR8+XAzucUYQ7g74gfgKFgbSy94uretw9F9S0GNH7aB5lb7QK0HDE7a Gf5OIaKilYd3Nx1WGwy6w4WNIeqvsqryzwcrU3eukJVdfzGQio+PclGkl0hHy7dIzp4b xsGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=JdEr7JFS+a6fS1u7tJOC/cfmSODhMrg80KdXF9LDMpQ=; b=BVonbGL8P9nV4JA/mqi8aIUIM1r/WfzQp00qvvrPMo9N2kTCRRqCRluf5RtCwDP+wT YN15dcydri6CsDmn9LL2d3Ilie0yuWeGvHRE0anUC+BJy3h1vRZO+nKRDEwUcugUGDZs Gp71Mg/oq1bgDleKtENfyC8jrEJ4DoR7IEraTsTCefOC44l7nEyLbuEgLkoqOMIlZ/vo 4pZ8seLzyFbCZ7Oyk+AJmPfPNz+nJ+YuuG3vASbzCTqlUJpAtF6UAQd/1/NFWJ4/W/1T WvkK4ytYwMvHOBzIBOmBSEcX7Hi7ftJHq6IgHhnLNHCbzV4c/+qDYurPBJ8jP5k6Tyqy FD1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ELRE9Pz+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si7715829edc.112.2020.09.05.19.20.58; Sat, 05 Sep 2020 19:21:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ELRE9Pz+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728774AbgIFCSO (ORCPT + 99 others); Sat, 5 Sep 2020 22:18:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728409AbgIFCSN (ORCPT ); Sat, 5 Sep 2020 22:18:13 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0179AC061573 for ; Sat, 5 Sep 2020 19:18:12 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id k25so12144402ljg.9 for ; Sat, 05 Sep 2020 19:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JdEr7JFS+a6fS1u7tJOC/cfmSODhMrg80KdXF9LDMpQ=; b=ELRE9Pz+/SWe5t3Fm1Fp9kkPikm4XFONxDCM3ctX1GcDCwx0ASgx0lP3wpzBwIaPlr SjLbrjECpSc0hOotuWXphZyCDda2i4kRqoC6Q2xlcVhlorYzQdbbfL5NrtVEwAtSLRVY Jm0EOgZRQZdTHCjQE8c4WB+yyBlTX7wxer8ZrS7PRhs1BxRdic2p2Bwx09ir3IDCz8YS QomIsTNOBSepP4M+8FA1H3i/JWYR6aDBSqj9SWjBvF4GRGr6KPc3Ndi1AR/bLSNGsetr dnwO3vGm6sgPB6tzWOQ10k7XXrtSZWZ2FeWlAkauxgIa83nu+xtdpcfTveCkwbOcy36f OtwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JdEr7JFS+a6fS1u7tJOC/cfmSODhMrg80KdXF9LDMpQ=; b=AfLhTZcVUrvWU8z6EMIcHVZ3SEpffRfm12PM+yut4Y8UHs4OjjRcrnjUytSEHxcs/0 uJJTJ9J/Eq2mXBE8hPj1nc6nD5opY9T1ODcdMFjRt/sST1q62JnQ3MK4DYpUAVfI8owd XiJnX6AeFBis3Ns47kU7CQp1GqgGScQe11JY8LhTcuDuc90EOUTu2bJKEMb+mnw556Dn xOBw7+x/1EjFxRHllP1CnoZFGKbmlcC5CeQPSv9vBx/erR2aZCBqHR6V4TsIltHACwuv WLJn+K6y4Z4qB2ns8or8RfPZl79UXntfAxD87bTCAeAhtBf1PrylmENbgdGQvooSBNJF fh4g== X-Gm-Message-State: AOAM5311JE5m78/ykPWKiigK63UsShEtbm8PS2qszyfEChcmvwfKgikh HgaSWT1THXxWzYk0dE7Ja2QN04n1x3IDnttShXE= X-Received: by 2002:a05:651c:2c9:: with SMTP id f9mr6904741ljo.257.1599358688242; Sat, 05 Sep 2020 19:18:08 -0700 (PDT) MIME-Version: 1.0 References: <1598995271-6755-1-git-send-email-jrdr.linux@gmail.com> <4d63100c-fe60-57ad-2924-7b28dbd14c20@nvidia.com> In-Reply-To: <4d63100c-fe60-57ad-2924-7b28dbd14c20@nvidia.com> From: Souptick Joarder Date: Sun, 6 Sep 2020 07:47:56 +0530 Message-ID: Subject: Re: [linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path To: John Hubbard Cc: Andrew Morton , Jason Gunthorpe , Dan Williams , Greg KH , timur@freescale.com, linux-kernel@vger.kernel.org, Dan Carpenter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 5, 2020 at 6:51 AM John Hubbard wrote: > > On 9/4/20 6:16 PM, Souptick Joarder wrote: > > Hi Andrew, > > > > On Wed, Sep 2, 2020 at 3:00 AM John Hubbard wrote: > >> > >> On 9/1/20 2:21 PM, Souptick Joarder wrote: > >>> First, when memory allocation for sg_list_unaligned failed, there > >>> is a bug of calling put_pages() as we haven't pinned any pages. > >>> > >>> Second, if get_user_pages_fast() failed we should unpin num_pinned > >>> pages. > >>> > >>> This will address both. > >>> > >>> As part of these changes, minor update in documentation. > >>> > >>> Fixes: 6db7199407ca ("drivers/virt: introduce Freescale hypervisor > >>> management driver") > >>> Signed-off-by: Souptick Joarder > >>> Reviewed-by: Dan Carpenter > >>> Reviewed-by: John Hubbard > >>> --- > >> > >> This looks good to me. > > > > Can you please take this patch through the mm tree ? > > > > Is there a problem with sending it through it's normal tree? It would probably > get better testing coverage there. scripts/get_maintainer.pl is showing only general lkml list and few commit signer. I didn't receive any feedback from anyone except you & Dan in more than 12+ weeks and mail bounced back from actual author Timur Tabi. As it is more than 12 weeks, I requested Andrew to take it through mm tree. Note - While running ./scripts/get_maintainer.pl, I observed one issue. Everytime I run the script, list is getting changed. Is it an expected behaviour ? Below is the details -> jordon@jordon-HP-15-Notebook-PC:~/Documents/virt/linux-next$ ./scripts/get_maintainer.pl 0001-drivers-virt-fsl_hypervisor-Fix-error-handling-path.patch Bjorn Andersson (commit_signer:1/1=100%) Daniel Vetter (commit_signer:1/1=100%) Dan Williams (commit_signer:1/1=100%) "Darren Hart (VMware)" (commit_signer:1/1=100%) Greg Kroah-Hartman (commit_signer:1/1=100%) Arnd Bergmann (authored:1/1=100%,added_lines:1/1=100%,removed_lines:1/1=100%,blamed_fixes:1/1=100%) Timur Tabi (blamed_fixes:1/1=100%) Kumar Gala (blamed_fixes:1/1=100%) linux-kernel@vger.kernel.org (open list) jordon@jordon-HP-15-Notebook-PC:~/Documents/virt/linux-next$ ./scripts/get_maintainer.pl 0001-drivers-virt-fsl_hypervisor-Fix-error-handling-path.patch Bjorn Andersson (commit_signer:1/1=100%) Daniel Vetter (commit_signer:1/1=100%) Dan Williams (commit_signer:1/1=100%) "Darren Hart (VMware)" (commit_signer:1/1=100%) Greg Kroah-Hartman (commit_signer:1/1=100%) Arnd Bergmann (authored:1/1=100%,added_lines:1/1=100%,removed_lines:1/1=100%,blamed_fixes:1/1=100%) Timur Tabi (blamed_fixes:1/1=100%) Kumar Gala (blamed_fixes:1/1=100%) linux-kernel@vger.kernel.org (open list) jordon@jordon-HP-15-Notebook-PC:~/Documents/virt/linux-next$ ./scripts/get_maintainer.pl 0001-drivers-virt-fsl_hypervisor-Fix-error-handling-path.patch Bjorn Andersson (commit_signer:1/1=100%) Daniel Vetter (commit_signer:1/1=100%) Dan Williams (commit_signer:1/1=100%) "Darren Hart (VMware)" (commit_signer:1/1=100%) Greg Kroah-Hartman (commit_signer:1/1=100%) Arnd Bergmann (authored:1/1=100%,added_lines:1/1=100%,removed_lines:1/1=100%,blamed_fixes:1/1=100%) Timur Tabi (blamed_fixes:1/1=100%) Kumar Gala (blamed_fixes:1/1=100%) linux-kernel@vger.kernel.org (open list) > > > thanks, > -- > John Hubbard > NVIDIA