Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1598851448-5493-1-git-send-email-amit.pundir@linaro.org>
 <CAMi1Hd3n2rfr+k09L8WO1S1Tn1s3xJencmr1q3a6e-FOgXr5Qg@mail.gmail.com>
 <CAMS8qEXcANkb-HoTk8zrXQEzkQO4cnFw4hj5tMp82UEVKd+eHQ@mail.gmail.com> <CAMi1Hd2ZakhXm+qNh-VMF_OndqCaQxxY3CC+UfQ6x2PyL_5sPQ@mail.gmail.com>
In-Reply-To: <CAMi1Hd2ZakhXm+qNh-VMF_OndqCaQxxY3CC+UfQ6x2PyL_5sPQ@mail.gmail.com>
From:   Konrad Dybcio <konradybcio@gmail.com>
Date:   Sun, 6 Sep 2020 16:35:20 +0200
Message-ID: <CAMS8qEVrSBPqtnMhAMY25yrUJ+M+3UrrGt+yikLaCyFDCUqCCw@mail.gmail.com>
Subject: Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)
To:     Amit Pundir <amit.pundir@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        dt <devicetree@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Thank you for the pointer. I dug around the vph_pwr fixed-regulator
> node used by fellow sdm845 devices. I assume it is safe to copy it
> from sdm845-mtp but I couldn't verify it in the downstream
> device-tree, so I'm a bit hesitant. My main concern is that I don't
> want to burn down my only device :)

Sure, nobody does ^^

> I did find a few regulator nodes downstream which matches with
> upstream sdm845-mtp but since I'm not using any of them in my
> beryllium dts, I'm going to skip them for now.

Looking at their DTSes, Xiaomi doesn't seem to stray far away from MTP designs.

> As you pointed out, in case of regulator lookup failure Linux will
> fall back to dummy regulators, which is working fine for me so far.
> Also I see that vdd-*-supply properties are optional according to
> Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt,
> so I assume it is safe to skip them?

Yes, but keep in mind it would be a good idea to add them later, after
you're sure everything's okay :)


P.S. My current daily driver is Xiaomi Mi 8, which is basically Poco
with an OLED and glass back (among some other minor nicer things), so
thanks for your work, I might benefit from it in the future :)

Konrad