Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alex Dewar <alex.dewar90@gmail.com>
Date:   Sun, 6 Sep 2020 20:48:50 +0100
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Alex Dewar <alex.dewar90@gmail.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Murali Karicheri <m-karicheri2@ti.com>,
        Thierry Reding <treding@nvidia.com>,
        Andrew Murray <amurray@thegoodpenguin.co.uk>,
        Vidya Sagar <vidyas@nvidia.com>,
        Dilip Kota <eswara.kota@linux.intel.com>,
        Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
        Jonathan Chocron <jonnyc@amazon.com>,
        linux-pci@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: keystone: Enable compile-testing on !ARM
Message-ID: <20200906194850.63glbnehjcuw356k@lenovo-laptop>
References: <20200904185609.171636-1-alex.dewar90@gmail.com>
 <CAJKOXPdjev5gMFBX8q6Q7ZZ1s3aBiGKOqfmrCQKTMGeXDeAoTA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJKOXPdjev5gMFBX8q6Q7ZZ1s3aBiGKOqfmrCQKTMGeXDeAoTA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Sep 06, 2020 at 02:19:44PM +0200, Krzysztof Kozlowski wrote:
> On Fri, 4 Sep 2020 at 20:56, Alex Dewar <alex.dewar90@gmail.com> wrote:
> >
> > Currently the Keystone driver can only be compile-tested on ARM, but
> > this restriction seems unnecessary. Get rid of it to increase test
> > coverage.
> >
> > Build-tested on x86 with allyesconfig.
> 
> You should at least build it on x86_64, powerpc and MIPS. These are
> widely available (e.g. in most of distros, or here:
> https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also
> riscv and sh (specially sh lacks certain headers/features).

Good suggestion. I've built it on x86, ppc, mips and riscv. sh wouldn't
build because of some kbuild dependency, rather than a compiler error.
I'll send a v2 with an updated commit message.

> 
> Best regards,
> Krzysztof