Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2930399pxk; Sun, 6 Sep 2020 20:07:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMIOZtW+L8MWWh7MfEuXZna6OQVXDKwjKwSgX5M15LKvJLNfW0VB+BztmF1Cd4O8LuGi3Q X-Received: by 2002:a17:906:1909:: with SMTP id a9mr18632937eje.127.1599448031510; Sun, 06 Sep 2020 20:07:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599448031; cv=none; d=google.com; s=arc-20160816; b=dIafcZovz0Q38O1Iyt0rfEumVwoS86kNicCzNQOdjc6pnfBk8/7AhubS/fYi3ZGOeL XbZNaXpJHOHDrRrXgsVaGolEIb3z79j83ikGkvpK+PPy38uI90TYVJZF3Pu/s8K95WFz aSkCXn63op8RV+f86PieZbUCAYr8eM6EP1vaFWVcbWiP3ZRXUb435ZSp1zLlIn+XNvK5 ob8xJRL07MhMsRkfkoaHO79RDPo1z9MHv9F+cfbAz65lzBm9E1ieN7YFQPtfIrxk4TIy BVKuYNVoxoT+Zd0qbJL1fG42bocjTVH+W02Kv9oitj/uMJQSdoHifhjwC9MGfR4ko+4R hYlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=p1ZvapJBq+DEvphWgn2wvDNmT5CLD8zjB/uU0KbGn9U=; b=D+LIbXLD/mp+Em+j3VSnTODC60JSNvuNtByiH6RYiNb4ZpGgi+BHcdMzwq9YIZvXLB OoySO+yuHvJwLjZ2Z+kSqmWbKmpB8g2rxHYgDfn2DM+gQfVM4RG9aAG9fz060O5JgBEa xPJNcWVQtk1PK6zyCULAli4tfSbIJMtx2hIjxp0VKXDK6brRshNqPtzNl/dZsMQmkKLX lRGQtd648kZg6HiVL6zjhjqPCG+PoEOeAYkgmBpbk/q7j7QlscgdnULQPk7EjJV3wX9J /1w84jEpGkl9imreR1ReHg+r5f7jG0Tqv3ne+SgCwXdlPDRLjfYZBCWsukicpCXyz/r+ gtOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a33si3143509ede.22.2020.09.06.20.06.49; Sun, 06 Sep 2020 20:07:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbgIGDGK (ORCPT + 99 others); Sun, 6 Sep 2020 23:06:10 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:51344 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726361AbgIGDGF (ORCPT ); Sun, 6 Sep 2020 23:06:05 -0400 Received: from localhost (unknown [192.168.167.235]) by lucky1.263xmail.com (Postfix) with ESMTP id 5E6D7CC468; Mon, 7 Sep 2020 10:59:38 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P22906T140609293825792S1599447567920103_; Mon, 07 Sep 2020 10:59:38 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: jay.xu@rock-chips.com X-SENDER: xjq@rock-chips.com X-LOGIN-NAME: jay.xu@rock-chips.com X-FST-TO: linus.walleij@linaro.org X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 From: Jianqun Xu To: linus.walleij@linaro.org, heiko@sntech.de Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Jianqun Xu Subject: [PATCH 3/5] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq Date: Mon, 7 Sep 2020 10:59:25 +0800 Message-Id: <20200907025927.9713-4-jay.xu@rock-chips.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907025927.9713-1-jay.xu@rock-chips.com> References: <20200831084753.7115-1-jay.xu@rock-chips.com> <20200907025927.9713-1-jay.xu@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There need to enable pclk_gpio when do irq_create_mapping, since it will do access to gpio controller. Reviewed-by: Heiko Stuebner Signed-off-by: Jianqun Xu --- drivers/pinctrl/pinctrl-rockchip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index cc7512acfc5f..58fd4d822591 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3157,7 +3157,9 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc, unsigned offset) if (!bank->domain) return -ENXIO; + clk_enable(bank->clk); virq = irq_create_mapping(bank->domain, offset); + clk_disable(bank->clk); return (virq) ? : -ENXIO; } -- 2.17.1