Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3017070pxk; Mon, 7 Sep 2020 00:04:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMTmU1Y7N6yvk1uTQx+aFYGz+WoBvzDdLjT5QWwU9MCqG03vLBncoqsWEYFSZskfyQ+zfF X-Received: by 2002:a17:906:455:: with SMTP id e21mr20773066eja.170.1599462265381; Mon, 07 Sep 2020 00:04:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599462265; cv=none; d=google.com; s=arc-20160816; b=sfsB9gDIcRVLGWz3FqIc/ScxSkLcrMYDk+yODGC0dNJiLy3mhvp39RJh/1K3+yaOlh rQBlJDbcDXFMrmS/ZiXckoMpjCk/lOXNpsSlwM+p+gQYz1FSTqXMzBrWUedi3mmlGzZc Xa+U0J8PKrELyIi5d1iqaERyCtIVv7LHwIDmAefnafJ37Incg3aYntTyHQg+PD8+l8te GoaZGLe2CDUeXVadKi505iQcxHig283wij1Cw0UOhNiQIcOlCVPssMgtuVZySBh/agf+ N6I2JGwFo+vhGk+QHAqDlNYOFwhcTGvAKU781w2redYrdLwJ5tbxkvgp/v4iuKEG3EqR QfNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mOwuNgBR5sDIJB+BvLt/e/G3W0U4pZcy6kQxubHpOsc=; b=DBaYIzJrmN3/alS7MOL3trwOQ9Yamk4XEtOrZmW1kJaxS6RpcNYG3nTXVKZc4eL8sy oNAXxh3a21HyEx7pQKH0nAtHfp/8v9ZbLHH9vB+62lpw/yboLuyUVLnQig05EsxC6bcg k1J8fEeXjO5hD6wxR/isBO7nFwHkWpnKOn7p2zbZCGbec9xzIOoy2eEhl9WY8RdeAgt1 lAmZA49si+aTuv7ZWRLRdwJMGJAxDOMz9lMSUtZH7+Wcohu+EnWnVJaeJhm8uFRERj5Q 6gIc9pQkj4s/1HpFDCWUp0e2YGe13buzwzuj02GX2EyDmSIdYKieRihAPESTtFhmZBIo bICQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=g4rWFwqP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z3si1272071ejw.415.2020.09.07.00.04.02; Mon, 07 Sep 2020 00:04:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=g4rWFwqP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgIGHBl (ORCPT + 99 others); Mon, 7 Sep 2020 03:01:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726420AbgIGHAn (ORCPT ); Mon, 7 Sep 2020 03:00:43 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A8BDC061573 for ; Mon, 7 Sep 2020 00:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mOwuNgBR5sDIJB+BvLt/e/G3W0U4pZcy6kQxubHpOsc=; b=g4rWFwqPV1Go6Awo3Xadh/+FTc rhkqVOirmN3euJ0YqlVMZuHmarTPW9k/+KBS0IBJiq7PF6T/kKmi+Jfc3KrgtB827pIK6HWC/Mdht 5xhoUhE0TgTLAd6RWIpqSgFwrqFKpVC7zMd2tCVTTzzCpWaSypFoADb7e9sp/QltHPE07bTrXlPCo jJpbTL7D5CEklu82hlfFs0pIt6EB91s9Pmo7ouUpJXku2JCl7cHofEBhAXLGEdBYyHfDd6vouz/NI JFp7LEB0sCZpyV49c8FZmuTBa8B14Fk7K9ICTPjCb0tLjN2FnTVYTfg2bFkUBB72NcK8nFsDXX9cL 9fzmjARw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFB8l-0006fv-7r; Mon, 07 Sep 2020 07:00:35 +0000 Date: Mon, 7 Sep 2020 08:00:35 +0100 From: Christoph Hellwig To: Tom Murphy Cc: iommu@lists.linux-foundation.org, David Woodhouse , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH V2 5/5] DO NOT MERGE: iommu: disable list appending in dma-iommu Message-ID: <20200907070035.GA25114@infradead.org> References: <20200903201839.7327-1-murphyt7@tcd.ie> <20200903201839.7327-6-murphyt7@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903201839.7327-6-murphyt7@tcd.ie> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 09:18:37PM +0100, Tom Murphy wrote: > Disable combining sg segments in the dma-iommu api. > Combining the sg segments exposes a bug in the intel i915 driver which > causes visual artifacts and the screen to freeze. This is most likely > because of how the i915 handles the returned list. It probably doesn't > respect the returned value specifying the number of elements in the list > and instead depends on the previous behaviour of the intel iommu driver > which would return the same number of elements in the output list as in > the input list. So what is the state of addressing this properly in i915? IF we can't get it done ASAP I wonder if we need a runtime quirk to disable merging instead of blocking this conversion..