Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/3] ARM: dts: exynos: Add assigned clock parent to
 CMU in Exynos3250
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sylwester Nawrocki <snawrocki@kernel.org>
From:   Sylwester Nawrocki <s.nawrocki@samsung.com>
Message-ID: <b092ef9e-b403-751e-22c3-65aa840267e6@samsung.com>
Date:   Mon, 7 Sep 2020 10:35:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
        Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200906124407.GA4829@kozik-lap>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20200903181437eucas1p16b97d1c425672700bac7ece19084584c@eucas1p1.samsung.com>
        <20200903181425.5015-1-krzk@kernel.org>
        <4bc2ea2e-65a2-6c0b-9557-5777e359241a@samsung.com>
        <20200906124407.GA4829@kozik-lap>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06.09.2020 14:44, Krzysztof Kozlowski wrote:
>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
>>> index a1e93fb7f694..89b160280469 100644
>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>> @@ -214,6 +214,7 @@
>>>   			compatible = "samsung,exynos3250-cmu";
>>>   			reg = <0x10030000 0x20000>;
>>>   			#clock-cells = <1>;
>>> +			clocks = <&cmu CLK_FIN_PLL>;
>> This is not a correct input clock for this CMU. Please assign it to 
>> xusbxti, xxti or xtcxo in the respective board dts, as this is a board 
>> property.

> Makes sense, although all this is kind of a hack as neither the bindings
> nor the driver take the input clock.

I think we should update the bindings so possible input clocks
to the CMU are documented for all SoCs. This is actually a bug 
in the clock controller DT bindings that the input clocks are
missing. Then the driver would handle both the old and the 
updated bindings but the "clocks" property would be documented 
as mandatory. I will try to have a look at this.