Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   Jianyong Wu <Jianyong.Wu@arm.com>
To:     Marc Zyngier <maz@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "yangbo.lu@nxp.com" <yangbo.lu@nxp.com>,
        "john.stultz@linaro.org" <john.stultz@linaro.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Mark Rutland <Mark.Rutland@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        Suzuki Poulose <Suzuki.Poulose@arm.com>,
        Steven Price <Steven.Price@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Steve Capper <Steve.Capper@arm.com>,
        Justin He <Justin.He@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64
Thread-Topic: [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64
Thread-Index: AQHWgp4Q48WtGxJp4kuFSJTL6o01LqlZ63wAgAL0nPA=
Date:   Mon, 7 Sep 2020 08:51:23 +0000
Message-ID: <HE1PR0802MB2555BAE6E8A0EC054258EDC6F4280@HE1PR0802MB2555.eurprd08.prod.outlook.com>
References: <20200904092744.167655-1-jianyong.wu@arm.com>
        <20200904092744.167655-9-jianyong.wu@arm.com> <871rjgmpa5.wl-maz@kernel.org>
In-Reply-To: <871rjgmpa5.wl-maz@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
nodisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: CoSRw4dX70UCoKUhaz5EmpGoQqk4KnA79NFQto9YD/SAb5VCv9rByrSXH7lCydKIq9COgNyHKuTAxQUFYIl7SfpUG54TASTUj4pssmcFp+aiiwQvmPlEf6TAJBa83rtEBiaAp8Eo/r9MgIb+xZWU/CpeO7SRELUkARUYT5mJhiif1OrRcgunW4LpfuYD8syy+A/SBOFykPdnETNSsRc2WMjwoMbgE7Tc1Bki8Zep32Kt+WoK3z+GAQVMd6jzw9cGHEvWebIn0gy1YYfFLJq0nUX0cXqxVo1gl0gZASpIuiUPoCwAdDesKKGWQMQsGvyGKsOvP2NhhyLw06P7pngfJg==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0802MB2555.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(316002)(54906003)(9686003)(8676002)(2906002)(5660300002)(53546011)(52536014)(7696005)(186003)(71200400001)(26005)(6916009)(55016002)(86362001)(83380400001)(478600001)(6506007)(66446008)(66556008)(66476007)(7416002)(8936002)(66946007)(64756008)(76116006)(33656002)(4326008);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: JSSa5tEGjvIxzO393PMtC5jTSS318irIguqwrdFjmNtqAC7BDaC2P09O7JAZGcO/JCQovhvpj7S9Pinake8s5cMW4S7hBEmtWMCBMDLI1oUIpgyRPA0tw76Ebw7wpySZNs5VjPhvqV46v0TlejlXQ2Kq+I4gde+UsB1Q5x+1YoydOzPeLStGRv6ATyhiA92EglBzcAvMdmNwmbcMwUI9G7wSYXU0tWYj1sipu5iq+9ELhLMVgmMdV2e0xQ0+XrzGl2R4I7Eh56WkdG7uxrce/14f+wIDB2wwnvtiBFnbDy404grQ9PwCdNpY2CbgmrTFpsLbzXeJFgj/hSERLXeeRuV56mpcdDr/O52er6pFFK3be0OEADsedr/tYApEc6NO56khZkrlNiyYYi0dt2M198SdD5GsRE4QfxEaL7OmcitCuBMPXRGi8UACCzqjHJtLbvTs7LIWr2Wq1xeq7KFKnEbR4QCSbps1Ip51tqUjSZUZJnxDmkzZeSZr8hvAZOWV8Abkvy+4qMTlNLNBdibraly42tqEATbepVTItrE0BZfdKwYxyL3X3l7POmnK15CTkqnKUJxXZJ/yIV0Dq2F9WMl2M844/JZLx7TIGd2EIY9iMQBGQcgUBe97pPBXmIsG85YFSJ+d4ntdgZO4z0kPng==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2700
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: cc190cae-e3bb-4342-8c49-08d8530b3343
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9SzhGlb14vz0DNV4Jj7pJ+/6JnYoAZdF24d9yuGk7tjm5pRe5T18hbDooAUVADO7x9gFZpEr5ybhD2RDjYiTS8X+uHTt0y3mTmrPfCfO2iJf+2yIBNyeT3Y6mAMQ7daWGMLlDjtjCeRbEJqixkXD1yaZ8KXLV76FvNQwPAFEK+D3PY34FLzSuSeplSJ/iKSN0FYJAXe9kmtO68a6UGmV31h9Q9uX3ImEWejwyRgwj99BA3qvzxqwn11ARkFl1nwMpJAcWFB/SwbWZRLtNyR8c5P2YqwSlwbypH/oEe229/Vd2kEw92+9NLWG1pN8tE1qa3aWgyRwMly8KxS4k+bbx1TQjvEhexwOmhPqP4ZXxKuc8k6EKEXt3ZT17ajj4v9W7eIb+D0J+VuIhehLwy9ivg==
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(46966005)(7696005)(450100002)(478600001)(5660300002)(70586007)(70206006)(52536014)(82740400003)(47076004)(6862004)(55016002)(83380400001)(81166007)(54906003)(82310400003)(9686003)(356005)(33656002)(4326008)(26005)(8676002)(186003)(86362001)(53546011)(6506007)(316002)(336012)(2906002)(36906005)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2020 08:51:34.3479
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b152d41-dc90-4dee-4711-08d8530b395a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1980
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Marc,

> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: Saturday, September 5, 2020 7:33 PM
> To: Jianyong Wu <Jianyong.Wu@arm.com>
> Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org;
> tglx@linutronix.de; pbonzini@redhat.com; sean.j.christopherson@intel.com;
> richardcochran@gmail.com; Mark Rutland <Mark.Rutland@arm.com>;
> will@kernel.org; Suzuki Poulose <Suzuki.Poulose@arm.com>; Steven Price
> <Steven.Price@arm.com>; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; kvmarm@lists.cs.columbia.edu;
> kvm@vger.kernel.org; Steve Capper <Steve.Capper@arm.com>; Justin He
> <Justin.He@arm.com>; nd <nd@arm.com>
> Subject: Re: [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64
>=20
> On Fri, 04 Sep 2020 10:27:42 +0100,
> Jianyong Wu <jianyong.wu@arm.com> wrote:
> >
> > Currently, there is no mechanism to keep time sync between guest and
> > host in arm64 virtualization environment. Time in guest will drift
> > compared with host after boot up as they may both use third party time
> > sources to correct their time respectively. The time deviation will be
> > in order of milliseconds. But in some scenarios,like in cloud
> > envirenment, we ask for higher time precision.
> >
> > kvm ptp clock, which choose the host clock source as a reference clock
> > to sync time between guest and host, has been adopted by x86 which
> > makes the time sync order from milliseconds to nanoseconds.
> >
> > This patch enables kvm ptp clock for arm64 and improve clock sync
> > precison significantly.
> >
> > Test result comparisons between with kvm ptp clock and without it in
> > arm64 are as follows. This test derived from the result of command
> > 'chronyc sources'. we should take more care of the last sample column
> > which shows the offset between the local clock and the source at the la=
st
> measurement.
> >
> > no kvm ptp in guest:
> > MS Name/IP address   Stratum Poll Reach LastRx Last sample
> >
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > ^* dns1.synet.edu.cn      2   6   377    13  +1040us[+1581us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377    21  +1040us[+1581us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377    29  +1040us[+1581us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377    37  +1040us[+1581us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377    45  +1040us[+1581us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377    53  +1040us[+1581us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377    61  +1040us[+1581us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377     4   -130us[ +796us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377    12   -130us[ +796us] +/-   21m=
s
> > ^* dns1.synet.edu.cn      2   6   377    20   -130us[ +796us] +/-   21m=
s
> >
> > in host:
> > MS Name/IP address   Stratum Poll Reach LastRx Last sample
> >
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > ^* 120.25.115.20          2   7   377    72   -470us[ -603us] +/-   18m=
s
> > ^* 120.25.115.20          2   7   377    92   -470us[ -603us] +/-   18m=
s
> > ^* 120.25.115.20          2   7   377   112   -470us[ -603us] +/-   18m=
s
> > ^* 120.25.115.20          2   7   377     2   +872ns[-6808ns] +/-   17m=
s
> > ^* 120.25.115.20          2   7   377    22   +872ns[-6808ns] +/-   17m=
s
> > ^* 120.25.115.20          2   7   377    43   +872ns[-6808ns] +/-   17m=
s
> > ^* 120.25.115.20          2   7   377    63   +872ns[-6808ns] +/-   17m=
s
> > ^* 120.25.115.20          2   7   377    83   +872ns[-6808ns] +/-   17m=
s
> > ^* 120.25.115.20          2   7   377   103   +872ns[-6808ns] +/-   17m=
s
> > ^* 120.25.115.20          2   7   377   123   +872ns[-6808ns] +/-   17m=
s
> >
> > The dns1.synet.edu.cn is the network reference clock for guest and
> > 120.25.115.20 is the network reference clock for host. we can't get
> > the clock error between guest and host directly, but a roughly
> > estimated value will be in order of hundreds of us to ms.
> >
> > with kvm ptp in guest:
> > chrony has been disabled in host to remove the disturb by network clock=
.
> >
> > MS Name/IP address         Stratum Poll Reach LastRx Last sample
> >
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > * PHC0                    0   3   377     8     -7ns[   +1ns] +/-    3n=
s
> > * PHC0                    0   3   377     8     +1ns[  +16ns] +/-    3n=
s
> > * PHC0                    0   3   377     6     -4ns[   -0ns] +/-    6n=
s
> > * PHC0                    0   3   377     6     -8ns[  -12ns] +/-    5n=
s
> > * PHC0                    0   3   377     5     +2ns[   +4ns] +/-    4n=
s
> > * PHC0                    0   3   377    13     +2ns[   +4ns] +/-    4n=
s
> > * PHC0                    0   3   377    12     -4ns[   -6ns] +/-    4n=
s
> > * PHC0                    0   3   377    11     -8ns[  -11ns] +/-    6n=
s
> > * PHC0                    0   3   377    10    -14ns[  -20ns] +/-    4n=
s
> > * PHC0                    0   3   377     8     +4ns[   +5ns] +/-    4n=
s
> >
> > The PHC0 is the ptp clock which choose the host clock as its source
> > clock. So we can see that the clock difference between host and guest
> > is in order of ns.
> >
> > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> > ---
> >  drivers/clocksource/arm_arch_timer.c | 24 +++++++++++++
> >  drivers/ptp/Kconfig                  |  2 +-
> >  drivers/ptp/ptp_kvm_arm64.c          | 53
> ++++++++++++++++++++++++++++
> >  3 files changed, 78 insertions(+), 1 deletion(-)  create mode 100644
> > drivers/ptp/ptp_kvm_arm64.c
>=20
> And I missed that one earlier:
>=20
> > diff --git a/drivers/clocksource/arm_arch_timer.c
> > b/drivers/clocksource/arm_arch_timer.c
> > index d55acffb0b90..aaf286e90092 100644
> > --- a/drivers/clocksource/arm_arch_timer.c
> > +++ b/drivers/clocksource/arm_arch_timer.c
> > @@ -1650,3 +1650,27 @@ static int __init arch_timer_acpi_init(struct
> > acpi_table_header *table)  }  TIMER_ACPI_DECLARE(arch_timer,
> > ACPI_SIG_GTDT, arch_timer_acpi_init);  #endif
> > +
> > +#if IS_ENABLED(CONFIG_PTP_1588_CLOCK_KVM)
> > +#include <linux/arm-smccc.h>
>=20
> No conditional includes, please.
>=20
Ok.

> > +int kvm_arch_ptp_get_crosststamp(unsigned long *cycle, struct
> timespec64 *ts,
> > +			      struct clocksource **cs)
> > +{
> > +	struct arm_smccc_res hvc_res;
> > +	ktime_t ktime;
> > +
> > +	/* Currently, linux guest will always use the virtual counter */
> > +
> 	arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FU
> NC_ID,
> > +			     ARM_PTP_VIRT_COUNTER, &hvc_res);
>=20
> You don't need to assume anything. This driver already provides you with =
the
> information you need to tell the hypervisor which counter to
> use:
>=20
> 	if (arch_timer_uses_ppi =3D=3D ARCH_TIMER_VIRT_PPI)
> 		ptp_counter =3D ARM_PTP_VIRT_COUNTER;
> 	else
> 		ptp_counter =3D ARM_PTP_PHYS_COUNTER;
> 	arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FU
> NC_ID,
> 			     ptp_counter, &hvc_res);
>=20
> At least, this is vaguely future proof.
>=20
> The hypervisor will still have to discriminate between a call between a c=
all
> from vEL1 or vEL2 to decide whether to subtract the offset from the count=
er
> value, but that's out of scope for now.

Very kind of you!

Thanks
Jianyong=20
>=20
> 	M.
>=20
> --
> Without deviation from the norm, progress is not possible.