Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3096285pxk; Mon, 7 Sep 2020 03:07:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoVI0EUsBOxuITXZw3nPWLXFNC9HtxgTNP5yuaUftk3vuZg6TkXmbFBbc06l+eb2aZ/b2N X-Received: by 2002:a17:906:328d:: with SMTP id 13mr21039289ejw.71.1599473256694; Mon, 07 Sep 2020 03:07:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599473256; cv=none; d=google.com; s=arc-20160816; b=PmVAZvrqaKyah3gP4YMKPYNiQOYtUg/tRGTYTxCWx/mKYv/GmllI3TDPB0CaXTMGqg 3NZ/bXdPZfQ4rEDTn0p/Od6+Y2wan9MhAXxHsEBQSF7hN9mBbSW8Fhn3ejM50SU3R75S 3CEys29/Xfm6cSuoT9HKUIJ6RKD4CXLqLYIcVvYSWRLaPH9cWoMnmXJVpOpeToWXCQjb egdxLi7LtZdfa8DxzqfAWpEHh2ytQCQRvhlqaA5JQ+5jvsd3+RfiRVY7O8/4GH8bK3Mh HBrIKLnb0bdp2I0Ear9yT2xvATSMWursScS3+1swZkcMIjJtv7O4LjL5nY8yBtpnr6bo moqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=UjUwAL1AyiFzPO5+tUUUXzj+Y5cff8+BbV8AFKpVhAg=; b=TuXvMym8nECqATJo++qflNlK4abcEAL+GS1n6Z56I5aXyr7MvutMzpxbWwKPJy0BG3 mScxczMbLGAbrVcMjPJX2HIsuX0//6fB4geUGib/qHZH+XPlaZKPD57QekukKWMacweO opnYMZfI7NmHkS9FegwqdKWsYMr6VIBKPlOk8AzL54T61iBcvtBRzJQwdX2zA2DT6XMY 5GZBfBAYDjbk6DzLIrtvzg2Ko8sAqNPyedHVYBTezPCdy3vCOqTFJhX3uXD7fMdwe8hh NAKTnuCQFJa3fZz6YJ0Mr3L7iDB68LJAgA4r7CzR48D8Ubnrh/VEdL/hHs1G92PHsMtB vG4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo4si9038648ejb.681.2020.09.07.03.07.14; Mon, 07 Sep 2020 03:07:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728424AbgIGKEg (ORCPT + 99 others); Mon, 7 Sep 2020 06:04:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728317AbgIGKEg (ORCPT ); Mon, 7 Sep 2020 06:04:36 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFBC6C061573 for ; Mon, 7 Sep 2020 03:04:35 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id EC9ED295A49 Subject: Re: [PATCH v3] platform: cros_ec: Reduce ligthbar get version command To: Gwendal Grignou , bleung@chromium.org, jic23@kernel.org Cc: linux-kernel@vger.kernel.org References: <20200830065937.2562679-1-gwendal@chromium.org> From: Enric Balletbo i Serra Message-ID: Date: Mon, 7 Sep 2020 12:04:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200830065937.2562679-1-gwendal@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gwendal, On 30/8/20 8:59, Gwendal Grignou wrote: > By default, the lightbar commands are set to the > biggest lightbar command and response. That length is greater than 128 > bytes and may not work on all machines. > But all EC are probed for lightbar by sending a get version request. > Set that request size precisely. > > Before the command would be: > cros_ec_cmd: version: 0, command: EC_CMD_LIGHTBAR_CMD, outsize: 194, insize: 128, result: 0 > Afer: > cros_ec_cmd: version: 0, command: EC_CMD_LIGHTBAR_CMD, outsize: 1, insize: 8, result: 0 > > Fixes: a841178445bb7 ("mfd: cros_ec: Use a zero-length array for command data") > Signed-off-by: Gwendal Grignou I changed the subject to match "platform/chrome: cros_ec_lightbar" and applied for 5.10. Thanks, Enric > --- > Changes since v2: > - Add fix field where the inefficiency was present. > > Changes since v1: > - Remove BUG and TEST fields. > > drivers/platform/chrome/cros_ec_lightbar.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c > index b59180bff5a3e..ef61298c30bdd 100644 > --- a/drivers/platform/chrome/cros_ec_lightbar.c > +++ b/drivers/platform/chrome/cros_ec_lightbar.c > @@ -116,6 +116,8 @@ static int get_lightbar_version(struct cros_ec_dev *ec, > > param = (struct ec_params_lightbar *)msg->data; > param->cmd = LIGHTBAR_CMD_VERSION; > + msg->outsize = sizeof(param->cmd); > + msg->result = sizeof(resp->version); > ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg); > if (ret < 0) { > ret = 0; >