Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3144743pxk; Mon, 7 Sep 2020 04:40:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAzFAwz6F1huK4OtNSWiw45OwDBzIhN2CDbKprMi2AHJFbUSHvrfx2SWLzA61DtudAhpNn X-Received: by 2002:aa7:dd8d:: with SMTP id g13mr21852881edv.324.1599478835454; Mon, 07 Sep 2020 04:40:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599478835; cv=none; d=google.com; s=arc-20160816; b=E3MWy7AzrVswRSALGmt5VWqUPhe0s1unTPt3DS++Rs5r1/VOtmSGisB6llDsCmRsIc ci8jqWrUCaLP41UAzyD+LIDUUnIEyVb2A4GYdUxbvwDoyDx3VjjXZRS1FUTg6TVynhEU w/s7jhBqoUSQ0HaP+/a2n3P3LdzwRDxszKqox4PO048R846+1BZilN23yUzmn+RB0w9F 810eq6Y6lnjF/nsiByqYQYRkB5RZc24GRIudkTk3BGRbUEgSSyeEWQYA2O0CoZ/2xG+K EZsKdwvJ6tiIErDT8PZGUPfboQJHhsHyCSoxtznNnlBbYxKCukOjPdyT1L/ZzdtrVrKG EvBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=NwCUFaPhMN/skHLwgR+yYwv+8o4l72dNE5sxGCsCq7s=; b=uv9qj+0Ve2dWqYhWa7FJHUAKhcoL51mNojaNaMqA1RN9iVem8Z+j/paYBqZsi3K0ee X9VuvLBZCa4LtExxESsE03Gt+IyJynZUgMBvJVczMjKVwQIsOyD1mdMHG9QkG3ji/vqq d2vkEOPgUvIeEPm1BGyjUL1HIQ6HYhixIU0D0vdmYuKtr25j5YnwVEGROpl/SjkQVLGq dUH2rcoRAeR4OBu1cFFWe2i7/VpJ+rR2w1kHPTFewxUQMfpK+3/n4FbqnGV5aCHVUy0e D+WhSm4E7jVrzaDid4JH7a8Xf58RCSEHmp0C1Fpu8bVg6r+wGaF98G8uMgHtGFxyWTN7 LaqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lqUWNcbk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j22si1258312edq.572.2020.09.07.04.40.13; Mon, 07 Sep 2020 04:40:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lqUWNcbk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729028AbgIGLhg (ORCPT + 99 others); Mon, 7 Sep 2020 07:37:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729055AbgIGLhT (ORCPT ); Mon, 7 Sep 2020 07:37:19 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69744C061573; Mon, 7 Sep 2020 04:37:18 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id i22so17798543eja.5; Mon, 07 Sep 2020 04:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=NwCUFaPhMN/skHLwgR+yYwv+8o4l72dNE5sxGCsCq7s=; b=lqUWNcbk5A+DnpTd7eQ++115FIy+qVDbyUIvQEYpY7qzS2PVj87gZlypM2XS+R7vL9 C44GaeEwCeF3tK56uwIjb+mP4Bi7UAL2n2G+RqwsNG1ATfFJsHzEUWcTXn9Ntzty9MHa pgU9I1Zmzk9+0wAhwIT3d//o57eZl+RvZqkSStEvG5KivKohNuPArWDT3PFYNNmb1RRm 3Mwfg8OMbsnbRzHlvhFUUuHyothXablhQNIocKEOIuhiCfb+5f9zd1lIhrBdQFgexupM Tt/jvk+Y07QDpvFqacfKWzTyE3p2txOB8nYOg9653dlv5EnzngK4bGs5zQ/0AuVDnD+H mW6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=NwCUFaPhMN/skHLwgR+yYwv+8o4l72dNE5sxGCsCq7s=; b=VMeM6kD8apuAy9iCq57TAXG1MzaXVxO2n0j89q7spXhbC3G6wSXkIjlN4UJ8OzAGvO AdKoEn/d7UzOaljzngUuKF+Tyx/xaJGch6kjaFlCWpRzj25ypqgpawrGYx+fkGxNT28f x2FEEn1HsPyOaf3LIVxxZ8tuYSzGY7dt/6VR3UVS/0siyqdvSefK1k0BQUx4iWX8y6vB ELAA3B7qvmd+YVr+ALFSLcXGbLXLaY3S+h5+OFQGvLCBo12j1oylxJPdeJvuRTaR2cRe IGbNkdbPZ6J0Od7iQfr5f79wxm8u+BFfD5zSO+njLYkDfT77z87ZTldk2kdasRLt75TB v4dw== X-Gm-Message-State: AOAM533/1BtADM+k22q/b3J+Tu9wWWMyKinTTj4Lykr3x/Ty/A7JUOi6 n4p8axH0xtJrfRr9LsHHTr8= X-Received: by 2002:a17:907:20e5:: with SMTP id rh5mr20474480ejb.267.1599478637051; Mon, 07 Sep 2020 04:37:17 -0700 (PDT) Received: from ubuntu-laptop ([2a01:598:b902:e05f:7139:914b:4eed:99b3]) by smtp.googlemail.com with ESMTPSA id 1sm15180447ejn.50.2020.09.07.04.37.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Sep 2020 04:37:16 -0700 (PDT) Message-ID: Subject: Re: [PATCH 0/2] use generic_file_buffered_read() From: Bean Huo To: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: beanhuo@micron.com Date: Mon, 07 Sep 2020 13:37:11 +0200 In-Reply-To: References: <20200904091341.28756-1-huobean@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-09-04 at 10:53 -0600, Jens Axboe wrote: > > Bean Huo (2): > > block: use generic_file_buffered_read() > > fs: isofs: use generic_file_buffered_read() > > The change is fine, but the title/commit message should reflect that > this is just a comment change. The way it currently reads, it sounds > like a functional change where something is switched over to using > generic_file_buffered_read(). > Hi Jens Indeed, it's easy to mistake this for a functional change, but it's actually a comment change. I have corrected them in the new patch, you can check now. thanks, Bean