Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3186416pxk; Mon, 7 Sep 2020 05:54:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkgeb3c1yMM4hbjNpLWnsgyDiav6Lc1j8pvJRf25STCAfJS8frcbJTu1z+Z7ysVpOVCIhb X-Received: by 2002:aa7:d593:: with SMTP id r19mr22138759edq.331.1599483250961; Mon, 07 Sep 2020 05:54:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599483250; cv=none; d=google.com; s=arc-20160816; b=Qu3IaqjjOASNMq+qxICUXv93sWtCc/EBZQAi9WobmU8sA+bx0ReCCvA+HrzZqAALey QX3NwfF9kvzVlEkhyFGHuS87t/UswzhAw7aJRTnDki90KTJwH9mTtkrZlOByzuYMkUo+ J63YwiQjXr5bJBIt2oLKfLknSUyINMsLIMBIITNsaG1tcwqjtcg85ljbmlR98s+noARo 8q8jlQfGu65tVxiSft63BWiBY2eh/7nnSoUNhmjg+JjFYji5yeH4uSzjdlHnWx5X1WZP 5BlqQDrhkGyiqIFnlYsiovZ6yDZEigQmaDYkirbLk5j9MMPRaW4p++51bxlqjviWBdUL jv1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=kAtYDm/B0qLUgQwlw3MkfDJ6jCXDr9PzGJ04pPlW4Io=; b=MeDWqs8HyV5/JiCDqbe7GkEsxEDmanQSj+rdrfO/W0hHo/sYlTb/5ai6a3hmp3ITKv PM44c3Yeham/36mRbxkLvcTPv/dH8acyOf2Tmjam1LkNzIoLGJotgxdgv7Hy913kkHcH FQSOyMxqueuayOXnP288EtwGbxfVg0B8xOS7Dz4Xt9No1zWByOJLBfke52Z8mySb+MO5 Rzu84LfJYbLfV8NSBOPAB/l4/qH2Gf9JYHaCjx+IDUCyncI+errF0E5zE2uyOyLiOnDm RrxVtAQchO4deNRMji7Ks80FDTWvqw/nWbjJPOyKNS5cY6H44GD8MFeqqS5X4Dn0RDWR I5UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si9894786edm.349.2020.09.07.05.53.48; Mon, 07 Sep 2020 05:54:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729326AbgIGMwy (ORCPT + 99 others); Mon, 7 Sep 2020 08:52:54 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:59210 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729043AbgIGMvX (ORCPT ); Mon, 7 Sep 2020 08:51:23 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 0D3ACEB8BDC1D413E296; Mon, 7 Sep 2020 20:50:43 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 7 Sep 2020 20:50:40 +0800 From: Zhang Changzhong To: , , CC: , Subject: [PATCH net-next] net: ethernet: fec: remove redundant null check before clk_disable_unprepare() Date: Mon, 7 Sep 2020 20:49:44 +0800 Message-ID: <1599482984-42783-1-git-send-email-zhangchangzhong@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.70] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because clk_prepare_enable() and clk_disable_unprepare() already checked NULL clock parameter, so the additional checks are unnecessary, just remove them. Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/freescale/fec_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index fb37816..c043afb 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1960,8 +1960,7 @@ static int fec_enet_clk_enable(struct net_device *ndev, bool enable) mutex_unlock(&fep->ptp_clk_mutex); } failed_clk_ptp: - if (fep->clk_enet_out) - clk_disable_unprepare(fep->clk_enet_out); + clk_disable_unprepare(fep->clk_enet_out); return ret; } -- 2.9.5