Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3198032pxk; Mon, 7 Sep 2020 06:10:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKriF7jIq6dbD/wHX/rtuhdsxxgh5gBHBjGnmm5aBVGOWuiiXNpk63BeCfMRT/5WbBziTU X-Received: by 2002:a17:906:6b95:: with SMTP id l21mr20383912ejr.317.1599484222442; Mon, 07 Sep 2020 06:10:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599484222; cv=none; d=google.com; s=arc-20160816; b=DeFoj2jh6zqgCiwqW2ByF/QIp1CHcHo1z1aqCGPnmOOa1/rKHlGKSvW5CzwTg5eZhO pzHDPXMy859jZzv7LUhHejgYAxq6QZJBMnHzOUkmqXxYTrHvqPXbBI0FO1b0Do0bYnho rMoeBMusgGyrUTLmffKrfkcHUhDjry5tjQNI90E2oXJbCocluBQ5G9mK/+qCGdUBj6p6 dbuTZ6GnftLFY54nxW8nplSzr419Pu+peJ7XeIlxOuZPolHsuKXQ0OQTNQVCXWRbUHiN HOvvLVJbl22B6JX1U8qrcgZT1rJkTfT6d3gIVfpNfgikQqUsa6O1bhMOd/DytO6LGg+L SpsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=tb3Qi9x0/rrZ0hT1uEtJNJ2/JxS1hYbK8ePOsC7m1H8=; b=xZLVZMyAStF49NLfkltsLqyBXeHbD0FhC5gaz+1BcjI+NvvYNBNdHii/GtlZsTcA3I JuhmFKx/wfnZ6fFhTWd6rhjEviqyVE8slQ1Z0qa/XJULmEcL49A8mZHQjgf63liv9UVs 8OpKpkpd3ZdpK/+WWX/qGxqQEivfgig0qI6AKcz/qrc0PTCgYLBJBEjnAbEIDtaETe0Y zDVJ40QTmgKEsaOygD7CsiH0ZT98v9GC+UR0A/nA0T8ZSth1aec0TGQecEnLxx/eDN7g qP4gpNj8IugG4Xwzrut0M9b1akZsvy5mlRZKJvfsncZmjA51eiyM+X79OiuHgSfSGGIH tYgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si1227739ejg.656.2020.09.07.06.10.00; Mon, 07 Sep 2020 06:10:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729408AbgIGNGH (ORCPT + 99 others); Mon, 7 Sep 2020 09:06:07 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:59776 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729318AbgIGNDK (ORCPT ); Mon, 7 Sep 2020 09:03:10 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 10F611C9B9968BC436E5; Mon, 7 Sep 2020 21:03:07 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 7 Sep 2020 21:03:03 +0800 From: Zhang Changzhong To: , , , CC: , Subject: [PATCH net-next] net: xilinx: remove redundant null check before clk_disable_unprepare() Date: Mon, 7 Sep 2020 21:02:03 +0800 Message-ID: <1599483723-43704-1-git-send-email-zhangchangzhong@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.70] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because clk_prepare_enable() and clk_disable_unprepare() already checked NULL clock parameter, so the additional checks are unnecessary, just remove them. Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index fa5dc299..9aafd3e 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2038,8 +2038,7 @@ static int axienet_remove(struct platform_device *pdev) axienet_mdio_teardown(lp); - if (lp->clk) - clk_disable_unprepare(lp->clk); + clk_disable_unprepare(lp->clk); of_node_put(lp->phy_node); lp->phy_node = NULL; -- 2.9.5