Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Radhey Shyam Pandey <radheys@xilinx.com>
To:     Zhang Changzhong <zhangchangzhong@huawei.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        Michal Simek <michals@xilinx.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next] net: xilinx: remove redundant null check before
 clk_disable_unprepare()
Thread-Topic: [PATCH net-next] net: xilinx: remove redundant null check before
 clk_disable_unprepare()
Thread-Index: AQHWhRc+nua2aTQ0EUCz2lx+OASiAaldJw0w
Date:   Mon, 7 Sep 2020 13:14:05 +0000
Message-ID: <BYAPR02MB5638CE555F06629B3EC83043C7280@BYAPR02MB5638.namprd02.prod.outlook.com>
References: <1599483723-43704-1-git-send-email-zhangchangzhong@huawei.com>
In-Reply-To: <1599483723-43704-1-git-send-email-zhangchangzhong@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6360e526-48f3-438e-5008-08d8532fe5d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2020 13:14:05.5577
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cVp/5/XpnFWFhqZykun/wr5Vs0vYyNLC+lGRsoeUVXusU2pki36Kk/erQCEDYlXEFTZjpWUwLiCZCg3gp4gXZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5735
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Zhang Changzhong <zhangchangzhong@huawei.com>
> Sent: Monday, September 7, 2020 6:32 PM
> To: Radhey Shyam Pandey <radheys@xilinx.com>; davem@davemloft.net;
> kuba@kernel.org; Michal Simek <michals@xilinx.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH net-next] net: xilinx: remove redundant null check before
> clk_disable_unprepare()
>=20
> Because clk_prepare_enable() and clk_disable_unprepare() already checked
> NULL clock parameter, so the additional checks are unnecessary, just
> remove them.
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>

Thanks!
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index fa5dc299..9aafd3e 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -2038,8 +2038,7 @@ static int axienet_remove(struct platform_device
> *pdev)
>=20
>  	axienet_mdio_teardown(lp);
>=20
> -	if (lp->clk)
> -		clk_disable_unprepare(lp->clk);
> +	clk_disable_unprepare(lp->clk);
>=20
>  	of_node_put(lp->phy_node);
>  	lp->phy_node =3D NULL;
> --
> 2.9.5