Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Sep 2020 16:56:13 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     "Ramuthevar,Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
        devicetree@vger.kernel.org, richard@nod.at, vigneshr@ti.com,
        arnd@arndb.de, brendanhiggins@google.com, tglx@linutronix.de,
        boris.brezillon@collabora.com, anders.roxell@linaro.org,
        masonccyang@mxic.com.tw, robh+dt@kernel.org,
        linux-mips@vger.kernel.org, hauke.mehrtens@intel.com,
        andriy.shevchenko@intel.com, cheol.yong.kim@intel.com,
        qi-ming.wu@intel.com
Subject: Re: [RESEND PATCH v12 2/2] mtd: rawnand: Add NAND controller
 support on Intel LGM SoC
Message-ID: <20200907165613.79f44c58@xps13>
In-Reply-To: <20200907152025.66c18f5e@xps13>
References: <20200817052709.47035-1-vadivel.muruganx.ramuthevar@linux.intel.com>
        <20200817052709.47035-3-vadivel.muruganx.ramuthevar@linux.intel.com>
        <20200907152025.66c18f5e@xps13>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Miquel Raynal <miquel.raynal@bootlin.com> wrote on Mon, 7 Sep 2020
15:20:25 +0200:

> Hi Murugan,
> 
> A few more comments below, but I guess the driver looks better now.
> 
> > +struct ebu_nand_controller {
> > +	struct nand_controller controller;
> > +	struct nand_chip chip;
> > +	struct device *dev;
> > +	void __iomem *ebu;
> > +	void __iomem *hsnand;
> > +	struct dma_chan *dma_tx;
> > +	struct dma_chan *dma_rx;
> > +	struct completion dma_access_complete;
> > +	unsigned long clk_rate;
> > +	struct clk *clk;
> > +	u32 nd_para0;
> > +	u8 cs_num;
> > +	struct ebu_nand_cs cs[MAX_CS];
> > +};
> > +
> > +static inline struct ebu_nand_controller *nand_to_ebu(struct nand_chip *chip)
> > +{
> > +	return container_of(chip, struct ebu_nand_controller, chip);
> > +}
> > +
> > +static u8 ebu_nand_readb(struct nand_chip *chip)  
> 
> Can't you prefix with intel_ instead of ebu_ ?

Actually not, as the IP is shared with MIPS IIUC, just ignore this
comment.

Thanks,
Miquèl