Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: text/plain; charset=us-ascii
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20200907142206.GL8670@sasha-vm>
Date:   Mon, 7 Sep 2020 16:42:02 +0200
Cc:     David Brazdil <dbrazdil@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Marc Zyngier <maz@kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3FB315D0-C65D-49C0-A632-6E103F1D02B7@goldelico.com>
References: <3750C774-62A4-4D02-8C07-6C98304F32F3@goldelico.com> <20200907142206.GL8670@sasha-vm>
To:     Sasha Levin <sashal@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

> Am 07.09.2020 um 16:22 schrieb Sasha Levin <sashal@kernel.org>:
>=20
> On Mon, Sep 07, 2020 at 03:29:40PM +0200, H. Nikolaus Schaller wrote:
>> Hi,
>> it seems as if your patch
>>=20
>> 34f379956e9d7 ("KVM: arm64: Fix symbol dependency in =
__hyp_call_panic_nvhe")
>> [ Upstream commit b38b298aa4397e2dc74a89b4dd3eac9e59b64c96 ]
>>=20
>> fails to compile in v5.8.7 for me (using an aarch64 gcc 4.9 =
cross-toolchain to try
>> to build a kernel for the PinePhone):
>>=20
>> CC      arch/arm64/kvm/hyp/switch.o - due to target missing
>> arch/arm64/kvm/hyp/switch.c: In function 'hyp_panic':
>> arch/arm64/kvm/hyp/switch.c:904:2: error: impossible constraint in =
'asm'
>> asm volatile("ldr %0, =3D%1" : "=3Dr" (str_va) : "S" =
(__hyp_panic_string));
>> ^
>=20
> Does upstream build correctly for you?

It is 100% upstream code in arch/arm64, just with a private config.
diff --stat arch/arm64 shows only 2 dts and 2 config files. It did
compile well with v5.8.5 and just broke after merge v5.8.7.

>=20
>> I can find the commit b38b298aa4397e2dc74a89b4dd3eac9e59b64c96 in =
upstream
>> but not the affected file. There is also "KVM: arm64: Split =
hyp/switch.c to VHE/nVHE"
>> which does a cleanup and rename and v5.9-rc4 compiles fine.
>=20
> Right, it got moved around in upstream.

Maybe this has fixed something...

BR and thanks,
Nikolaus