Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Sep 2020 18:15:31 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc:     Thorsten Scherer <t.scherer@eckelmann.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        linux-gpio@vger.kernel.org, tglx@linutronix.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gpio: siox: explicitly support only threaded irqs
Message-ID: <20200907161531.x7wdxmb5e3qdbtn7@pengutronix.de>
References: <20200907153135.3307-1-a.fatoum@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cgjxmmqsfjfxvawn"
Content-Disposition: inline
In-Reply-To: <20200907153135.3307-1-a.fatoum@pengutronix.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--cgjxmmqsfjfxvawn
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Ahmad,

On Mon, Sep 07, 2020 at 05:31:35PM +0200, Ahmad Fatoum wrote:
> The gpio-siox driver uses handle_nested_irq() to implement its
> interrupt support. This is only capable of handling threaded irq
> actions. For a hardirq action it triggers a NULL pointer oops.
> (It calls action->thread_fn which is NULL then.)
>=20
> Prevent registration of a hardirq action by setting
> gpio_irq_chip::threaded to true.

cool commit log :-)

> Cc: u.kleine-koenig@pengutronix.de
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Thanks for picking this up.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--cgjxmmqsfjfxvawn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl9WXKAACgkQwfwUeK3K
7Alg0Qf/VlxWkLp9Bpt+uYNTELqmDL/zHOIn4GQTGgJrM34u8CTDAlLetTFtr9OW
edbUtd2vWanorXEl3qdPxqi31FmgbQljDmwOu15VQuEsSzb8mNMkSRP2BOuiCRas
B10LsGriMod8/49H2A5UVhSs/cNVT0JiLgPxQIssWYulH07agqHlSNCeMmgf7GTA
6JJHYUl/Mld/qnKABxDUIYTTv70U9tXO2KsSkOFs4IF9AZIroQayBiDyDDvxJrPB
gt0SpzcHMFE7to6edyGIbdxU+ag22FzL/XJnDM2EALjr6c7vAX6n9ui1HpZ7BNsI
WEA54N3FLA5A1MYwDqwnhKwVVMhGUA==
=J3Py
-----END PGP SIGNATURE-----

--cgjxmmqsfjfxvawn--