Date: Mon, 29 May 2006 11:43:26 +0200
From: Jan Blunck <jblunck@suse.de>
To: David Chinner <dgc@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       viro@zeniv.linux.org.uk
Subject: Re: [patch 4/5] vfs: per superblock dentry stats
Message-ID: <20060529094326.GF21024@hasse.suse.de>
References: <20060526110655.197949000@suse.de>> <20060526110802.852609000@suse.de> <20060529022401.GT8069029@melbourne.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060529022401.GT8069029@melbourne.sgi.com>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1330
Lines: 41

On Mon, May 29, David Chinner wrote:

> > -struct dentry_stat_t {
> > +struct dentry_stat {
> >  	int nr_dentry;
> >  	int nr_unused;
> > -	int age_limit;          /* age in seconds */
> > -	int want_pages;         /* pages requested by system */
> > -	int dummy[2];
> > +	int age_limit;		/* age in seconds */
> >  };
> 
> that changes the size of the structure from 6*sizeof(int) to
> 3*sizeof(int)....
> 
> > Index: work-2.6/kernel/sysctl.c
> > ===================================================================
> > --- work-2.6.orig/kernel/sysctl.c
> > +++ work-2.6/kernel/sysctl.c
> > @@ -958,7 +958,7 @@ static ctl_table fs_table[] = {
> >  	{
> >  		.ctl_name	= FS_DENTRY,
> >  		.procname	= "dentry-state",
> > -		.data		= &dentry_stat,
> > +		.data		= &global_dentry_stat,
> >  		.maxlen		= 6*sizeof(int),
> 
> With the above change, maxlen = 3*sizeof(int).
> 
> Given that's a userspace visible change, should the above structure
> change use a "int dummy[3];" to keep the global structure and userspace
> export the same?

Hmm, probably you are right. I'll change this.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/