Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Sep 2020 19:42:00 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Andre Heider <a.heider@gmail.com>
Cc:     Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Tomasz Maciej Nowak <tmn505@gmail.com>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch
 aliases
Message-ID: <20200907174200.yqojaguthi6khn3v@pali>
References: <20200907112718.5994-1-pali@kernel.org>
 <3ec54259-4bfe-8462-e8d5-083fc009707a@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3ec54259-4bfe-8462-e8d5-083fc009707a@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Monday 07 September 2020 19:13:41 Andre Heider wrote:
> > @@ -120,7 +124,7 @@
> >   			#address-cells = <1>;
> >   			#size-cells = <0>;
> > -			port@0 {
> > +			switch0port0: port@0 {
> 
> This label is unused it seems.

Yes, it is unused, but I defined labels for all ports so it would be
clean that ports are indexed from zero and not from one. Also it looks
inconsistent if some of DSA ports have labels and some does not.

> 
> >   				reg = <0>;
> >   				label = "cpu";
> >   				ethernet = <&eth0>;
> > @@ -131,19 +135,19 @@
> >   				};
> >   			};
> > -			port@1 {
> > +			switch0port1: port@1 {
> >   				reg = <1>;
> >   				label = "wan";
> >   				phy-handle = <&switch0phy0>;
> >   			};
> > -			port@2 {
> > +			switch0port2: port@2 {
> >   				reg = <2>;
> >   				label = "lan0";
> >   				phy-handle = <&switch0phy1>;
> >   			};
> > -			port@3 {
> > +			switch0port3: port@3 {
> >   				reg = <3>;
> >   				label = "lan1";
> >   				phy-handle = <&switch0phy2>;
> > 
>