Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch
 aliases
To:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>
Cc:     Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Tomasz Maciej Nowak <tmn505@gmail.com>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200907112718.5994-1-pali@kernel.org>
 <3ec54259-4bfe-8462-e8d5-083fc009707a@gmail.com>
 <20200907174200.yqojaguthi6khn3v@pali>
From:   Andre Heider <a.heider@gmail.com>
Message-ID: <9c0e3c31-866d-d53a-5a5c-d66e2da27f6c@gmail.com>
Date:   Mon, 7 Sep 2020 19:44:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.1
MIME-Version: 1.0
In-Reply-To: <20200907174200.yqojaguthi6khn3v@pali>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/09/2020 19:42, Pali Rohár wrote:
> On Monday 07 September 2020 19:13:41 Andre Heider wrote:
>>> @@ -120,7 +124,7 @@
>>>    			#address-cells = <1>;
>>>    			#size-cells = <0>;
>>> -			port@0 {
>>> +			switch0port0: port@0 {
>>
>> This label is unused it seems.
> 
> Yes, it is unused, but I defined labels for all ports so it would be
> clean that ports are indexed from zero and not from one. Also it looks
> inconsistent if some of DSA ports have labels and some does not.

Alright, sounds good:
Reviewed-by: Andre Heider <a.heider@gmail.com>

> 
>>
>>>    				reg = <0>;
>>>    				label = "cpu";
>>>    				ethernet = <&eth0>;
>>> @@ -131,19 +135,19 @@
>>>    				};
>>>    			};
>>> -			port@1 {
>>> +			switch0port1: port@1 {
>>>    				reg = <1>;
>>>    				label = "wan";
>>>    				phy-handle = <&switch0phy0>;
>>>    			};
>>> -			port@2 {
>>> +			switch0port2: port@2 {
>>>    				reg = <2>;
>>>    				label = "lan0";
>>>    				phy-handle = <&switch0phy1>;
>>>    			};
>>> -			port@3 {
>>> +			switch0port3: port@3 {
>>>    				reg = <3>;
>>>    				label = "lan1";
>>>    				phy-handle = <&switch0phy2>;
>>>
>>