Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch
 aliases
To:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Tomasz Maciej Nowak <tmn505@gmail.com>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200907112718.5994-1-pali@kernel.org>
 <3ec54259-4bfe-8462-e8d5-083fc009707a@gmail.com>
 <20200907172303.GA3254313@lunn.ch> <20200907173534.aoupftjkxgcftfqo@pali>
 <f8cce9af-372b-f2bc-ea09-e1516367cb90@gmail.com>
 <20200907174705.clknw4375smvt47o@pali>
From:   Andre Heider <a.heider@gmail.com>
Message-ID: <97cce972-201f-dc54-644d-37bbbf369632@gmail.com>
Date:   Mon, 7 Sep 2020 19:50:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.1
MIME-Version: 1.0
In-Reply-To: <20200907174705.clknw4375smvt47o@pali>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/09/2020 19:47, Pali Rohár wrote:
> On Monday 07 September 2020 19:43:08 Andre Heider wrote:
>> On 07/09/2020 19:35, Pali Rohár wrote:
>>> On Monday 07 September 2020 19:23:03 Andrew Lunn wrote:
>>>>> My dts-foo is a little rusty, but now that you labeled the ports in the
>>>>> .dtsi, can this whole "switch0" block reduced to something like:
>>>>>
>>>>> &switch0port1 {
>>>>> 	label = "lan1";
>>>>> };
>>>>>
>>>>> &switch0port3 {
>>>>> 	label = "wan";
>>>>> };
>>>>
>>>> Probably yes.
>>>>
>>>> But that is definitely too much for stable.
>>>
>>> Yes, this suggested change is not for stable, but looks like a nice
>>> cleanup. So it could be done in followup patch.
>>>
>>> Andre, are you going to prepare and test this followup change?
>>
>> I can prep the patch if you like, but the suggested cleanup only affects the
>> v7 dts files. I don't have that hardware version to test it, so could only
>> send an untested patch.
> 
> As a result of this cleanup should be binary DTB file for V7 with same
> structure as DTB file without such cleanup patch, right? And this test
> (structure / content of compiled file) does not need particular hardware.

Ok, will do.