Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     Krzysztof Kozlowski <krzk@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        "linux-arm-kernel\@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-samsung-soc\@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
        "m.szyprowski\@samsung.com" <m.szyprowski@samsung.com>,
        "b.zolnierkie\@samsung.com" <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter
 Driver
Date:   Mon, 07 Sep 2020 20:06:56 +0200
In-Reply-To: <1efebb42c30a4c40bf91649d83d60e1c@AcuMS.aculab.com> (David
        Laight's message of "Wed, 26 Aug 2020 15:06:51 +0000")
Message-ID: <dleftjk0x5qx4v.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <1efebb42c30a4c40bf91649d83d60e1c@AcuMS.aculab.com>
        <CGME20200907180715eucas1p1c1e41bb1ddb5a401a4d9c8cb6117e1f6@eucas1p1.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-08-26 =C5=9Bro 15:06>, when David Laight wrote:
> From: Lukasz Stelmach
>> Sent: 26 August 2020 15:59
>>=20
>> It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote:
>> > On Tue, Aug 25, 2020 at 07:03:09PM +0200, =C5=81ukasz Stelmach wrote:
>> >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
>> >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
>> >> supports SPI connection.
> ...
>> >> +++ b/drivers/net/ethernet/asix/Kconfig
>> >> @@ -0,0 +1,20 @@
>> >> +#
>> >> +# Asix network device configuration
>> >> +#
>> >> +
>> >> +config NET_VENDOR_ASIX
>> >> +	bool "Asix devices"
>> >> +	depends on SPI
>> >> +	help
>> >> +	  If you have a network (Ethernet) interface based on a chip from A=
SIX, say Y
>> >
>> > Looks like too long, did it pass checkpatch?
>>=20
>> Yes? Let me try again. Yes, this one passed, but I missed a few other
>> problems. Thank you.
>>=20
>> >> +
>> >> +if NET_VENDOR_ASIX
>> >> +
>> >> +config SPI_AX88796C
>> >> +	tristate "Asix AX88796C-SPI support"
>> >> +	depends on SPI
>> >> +	depends on GPIOLIB
>> >> +	help
>> >> +	  Say Y here if you intend to attach a Asix AX88796C as SPI mode
>> >> +
>> >> +endif # NET_VENDOR_ASIX
>
> There are plenty of other ethernet devices made by ASIX (eg USB ones)
> that have nothing at all to do with this driver.
> So those questions are too broad.
>
> The first one should probable be for ASIX SPI network devices.
>

On the other hand there is only one ASIX SPI network device and there
are four other Non-PCI AX88* chips (and that is all I know about them).

> (I can't imagine SPI being fast enough to be useful for ethernet...)

Not for a file server, sure. It handles clock up to 40MHz and it's meant
for systems that cannot handle more than a few MB/s anyway.

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl9WdsEACgkQsK4enJil
gBCEDwf/ZAzzxZQsYFkciKV12hSut3cBhW9zfz+Zbxu1YFnFrPRfBmdwn7vmP8vb
uJTacwtFJ3OAJiWhQIt7r4tb/Uh1lK9S/kjVDABUtssuGj8YDgbBKUVdeA1ESPy9
u3wl2aId3k9NPp6sshwqb9Wmigqh6SjsA9hLvxQEBgfOrjvh95JA0TYqrmRijyn2
k1YitbAzKa5uIh1GziCGwehfvOxALSg09uCkA7mr/yRpjbmvrlitNlfQA+at0XWy
d+f0T474TbGCVDIxIV2f8+HFe3iOPeZJxFOkjiEi9PclaB/arQvbhT6IxJd3mIei
g/+F/BYB/aiBxxSLgg3Q3XL7YY6ecA==
=/xTC
-----END PGP SIGNATURE-----
--=-=-=--