Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require
 syscon on S5Pv210
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        =?UTF-8?Q?Pawe=c5=82_Chmiel?= <pawel.mikolaj.chmiel@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
References: <20200907161141.31034-1-krzk@kernel.org>
 <20200907161141.31034-4-krzk@kernel.org>
From:   Jonathan Bakker <xc-racer2@live.ca>
Message-ID: <BN6PR04MB06601B8D0B7F1E51953024E6CB280@BN6PR04MB0660.namprd04.prod.outlook.com>
Date:   Mon, 7 Sep 2020 14:49:49 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20200907161141.31034-4-krzk@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2001:569:fb68:9c00:8067:f823:1e15:7520] (2001:569:fb68:9c00:8067:f823:1e15:7520) by MWHPR19CA0080.namprd19.prod.outlook.com (2603:10b6:320:1f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15 via Frontend Transport; Mon, 7 Sep 2020 21:49:51 +0000
X-Microsoft-Original-Message-ID: <9b86ea56-6afe-cbcc-52a3-c75d23e1a62b@live.ca>
X-TMN:  [JiSKL8DRPDgGXdBt/+WDUrQFhwTmujX7oj3voAQmvt6O/7c6QorpjXIzJy99aXK4]
X-MS-PublicTrafficType: Email
X-IncomingHeaderCount: 48
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-Correlation-Id: e9a8be77-b337-4d60-ff26-08d85377f3fe
X-MS-TrafficTypeDiagnostic: BY5PR21MB1425:
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RZBATa1ANBuEEWeAOgHwvgXo1rkandmR8L9qf2nVmlCDvlPqgBdjOH3mSwlkjyJlgo8QjMvd9EM4Z6J+wBmA6G8lW/24PDRdg1dTgduBpPrpbo4uOpDpxEFXHyAN/+SgQAseLtKFryq5qfO1WeV0I1OLfUzC4hPf8icxmekt4XZOiZyjbHkiG4i0komPs2l6RWYbocg0mC/POOxll1FBOsxBPAx1RugCZqeRtk8DVizJUhNXxXSmjQmbjYey+jQ8
X-MS-Exchange-AntiSpam-MessageData: s4E5NVFRl+DuTndJRm2WiohbiCEGNorz0s6efxlXn9uKz4j51wgC92SqoyQ6lSTManYtXdAQdgjbUwv1IButgRAIyTOd/RdX2NSlj2XE7BMjGuQtnF9EQDOqRdvTYDybqeMWK1A3sUki8c9qBEJdpTpHOW8IrZuoqy8ZAsZbbrH9WN1Yyma0PwKMMHeyRZzCs+uJePKTV9pW+QzSuFzQ9w==
X-OriginatorOrg: sct-15-20-3174-0-msonline-outlook-fb0b2.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: e9a8be77-b337-4d60-ff26-08d85377f3fe
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2020 21:49:53.7011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT031.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR21MB1425
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looking at this again, it appears that there is actually control for
it at offset 0x6818 of pmu_syscon (0xe0108000) [1].  However, it defaults to
enabled so it's not required for proper use of the block.  Whether it should
be present in the schema/DTS is up to you.

Thanks,
Jonathan

[1] https://android.googlesource.com/kernel/samsung/+/refs/heads/android-samsung-3.0-jb-mr0/arch/arm/mach-s5pv210/include/mach/regs-clock.h#325

On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The ADC in S5Pv210 does not have ADC phy registers in separate block for
> which syscon would be needed.  Remove this requirement to fix dtbs_check
> warnings like:
> 
>   arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml          | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index 89b4f9c252a6..75174af72288 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -81,7 +81,6 @@ allOf:
>                - samsung,exynos-adc-v2
>                - samsung,exynos3250-adc
>                - samsung,exynos4212-adc
> -              - samsung,s5pv210-adc
>      then:
>        required:
>          - samsung,syscon-phandle
>