Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFT 06/25] ARM: dts: s5pv210: move fixed clocks under root node
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        =?UTF-8?Q?Pawe=c5=82_Chmiel?= <pawel.mikolaj.chmiel@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
References: <20200907161141.31034-1-krzk@kernel.org>
 <20200907161141.31034-7-krzk@kernel.org>
From:   Jonathan Bakker <xc-racer2@live.ca>
Message-ID: <BN6PR04MB06608B88962AD3D8BF5301D3CB280@BN6PR04MB0660.namprd04.prod.outlook.com>
Date:   Mon, 7 Sep 2020 14:59:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20200907161141.31034-7-krzk@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2001:569:fb68:9c00:8067:f823:1e15:7520] (2001:569:fb68:9c00:8067:f823:1e15:7520) by CO2PR18CA0056.namprd18.prod.outlook.com (2603:10b6:104:2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16 via Frontend Transport; Mon, 7 Sep 2020 21:59:31 +0000
X-Microsoft-Original-Message-ID: <d6d74e49-57f0-506e-289a-b6cc786cabe0@live.ca>
X-TMN:  [G6aTOyxuKOyt7jjK6HKCYUMiKhFeVfuFcb+vC0+Z1TT0ipj2LYdB/aXmC66kDrSu]
X-MS-PublicTrafficType: Email
X-IncomingHeaderCount: 48
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-Correlation-Id: c03078b4-7411-41d1-3092-08d853794df6
X-MS-TrafficTypeDiagnostic: BN7NAM10HT177:
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ftYHjl3RitJDUNld+16ZH5kVvuAyRhChR3oPbMONp6+A9wzbNLCE78J8+jxz2FvjB74XxSfvl6Ga7NmhQM8wBNsjDKJ/bemTdeTapMwlV7dKR0F9mhE91Upn0X5AzLud+w+HSxp93EsYQW9NGkjaNNrCbM5gfXJ+zBwR7QOO/OzdTqEPhUX7T57ziZ3oDehNPp3eXvFobGLY8W32QcwB1A==
X-MS-Exchange-AntiSpam-MessageData: uKWby0FG/2bXOfx9WCUJnonk84yAgpFz03LYGbSFUMJ4ZCpoJLOGDbIo+VhV3AzLChgV6CVnKLnr3kLqQB6tFB1b5C0Z7PqF78JBPryR5oUz2dQMwhLeL9260/sxtJDtpWMi25avyUlieZxEtZgi8gZ1AL5Wi1enpjAKK9ozpVwrD7BFNY30ZLA56qAqv4gcsg3CFk9GWYxEKOWsFCimWQ==
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c03078b4-7411-41d1-3092-08d853794df6
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2020 21:59:34.0332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT016.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT177
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Works for me on the Galaxy S.

Tested-by: Jonathan Bakker <xc-racer2@live.ca>

Thanks,
Jonathan

On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The fixed clocks are kept under dedicated 'external-clocks' node, thus a
> fake 'reg' was added.  This is not correct with dtschema as fixed-clock
> binding does not have a 'reg' property.  Moving fixed clocks out of
> 'soc' to root node fixes multiple dtbs_check warnings:
> 
>   external-clocks: $nodename:0: 'external-clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
>   external-clocks: #size-cells:0:0: 0 is not one of [1, 2]
>   external-clocks: oscillator@0:reg:0: [0] is too short
>   external-clocks: oscillator@1:reg:0: [1] is too short
>   external-clocks: 'ranges' is a required property
>   oscillator@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm/boot/dts/s5pv210.dtsi | 36 +++++++++++++---------------------
>  1 file changed, 14 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 84e4447931de..5c760a6d7955 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -52,34 +52,26 @@
>  		};
>  	};
>  
> +	xxti: oscillator-0 {
> +		compatible = "fixed-clock";
> +		clock-frequency = <0>;
> +		clock-output-names = "xxti";
> +		#clock-cells = <0>;
> +	};
> +
> +	xusbxti: oscillator-1 {
> +		compatible = "fixed-clock";
> +		clock-frequency = <0>;
> +		clock-output-names = "xusbxti";
> +		#clock-cells = <0>;
> +	};
> +
>  	soc {
>  		compatible = "simple-bus";
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		ranges;
>  
> -		external-clocks {
> -			compatible = "simple-bus";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
> -
> -			xxti: oscillator@0 {
> -				compatible = "fixed-clock";
> -				reg = <0>;
> -				clock-frequency = <0>;
> -				clock-output-names = "xxti";
> -				#clock-cells = <0>;
> -			};
> -
> -			xusbxti: oscillator@1 {
> -				compatible = "fixed-clock";
> -				reg = <1>;
> -				clock-frequency = <0>;
> -				clock-output-names = "xusbxti";
> -				#clock-cells = <0>;
> -			};
> -		};
> -
>  		onenand: onenand@b0600000 {
>  			compatible = "samsung,s5pv210-onenand";
>  			reg = <0xb0600000 0x2000>,
>