Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/mediatek: add missing put_device() call in
 mtk_ddp_comp_init()
To:     Chun-Kuang Hu <chunkuang.hu@kernel.org>
CC:     Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        <yt.shen@mediatek.com>, CK Hu <ck.hu@mediatek.com>,
        Bibby Hsieh <bibby.hsieh@mediatek.com>,
        Yongqiang Niu <yongqiang.niu@mediatek.com>,
        "DRI Development" <dri-devel@lists.freedesktop.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        <yi.zhang@huawei.com>
References: <20200905083058.1631726-1-yukuai3@huawei.com>
 <CAAOTY_-BQx0rozw0qoGj1bt4hO2rFmYvKrjQHbA-K04txUWW+w@mail.gmail.com>
From:   "yukuai (C)" <yukuai3@huawei.com>
Message-ID: <e10c0375-8ef3-a2ba-b23f-f80d082e1ba7@huawei.com>
Date:   Tue, 8 Sep 2020 09:05:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <CAAOTY_-BQx0rozw0qoGj1bt4hO2rFmYvKrjQHbA-K04txUWW+w@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/09/08 6:56, Chun-Kuang Hu wrote:
> Hi Yu Kuai:
> 
> Yu Kuai <yukuai3@huawei.com> 於 2020年9月5日 週六 下午4:31寫道：
>>
>> if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have
>> a corresponding put_device(). Thus add put_device() to fix the exception
>> handling for this function implementation.
>>
> 
> This patch looks good to me, but I find another thing related to this.
> mtk_ddp_comp_init() is called in a loop in mtk_drm_probe(), when this
> component init fail, I think we should uninitialize previous
> successive init component and put their device. Would you like to make
> this patch more complete?

Hi,

Of course, thank you for your review.

Best regards,
Yu Kuai