Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Sep 2020 09:33:33 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Andre Heider <a.heider@gmail.com>
Cc:     Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Tomasz Maciej Nowak <tmn505@gmail.com>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet
 port labeling
Message-ID: <20200908073333.i4mpjfcay42kkhq5@pali>
References: <20200908073050.535919-1-a.heider@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200908073050.535919-1-a.heider@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tuesday 08 September 2020 09:30:50 Andre Heider wrote:
> Now that the switch ports have a label in the .dtsi, simplify the whole
> "switch0" block for the v7 dts files.
> 
> Signed-off-by: Andre Heider <a.heider@gmail.com>

Thank you, looks good!

Reviewed-by: Pali Rohár <pali@kernel.org>

> ---
> 
> This goes on top of Pali's patch:
> "arm64: dts: marvell: espressobin: Add ethernet switch aliases"
> 
> The resulting .dtb files are the same.
> 
>  .../armada-3720-espressobin-v7-emmc.dts        | 18 +++++-------------
>  .../dts/marvell/armada-3720-espressobin-v7.dts | 18 +++++-------------
>  2 files changed, 10 insertions(+), 26 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 215d2f702623..61d49d6a2a2a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -28,20 +28,12 @@ aliases {
>  	};
>  };
>  
> -&switch0 {
> -	ports {
> -		switch0port1: port@1 {
> -			reg = <1>;
> -			label = "lan1";
> -			phy-handle = <&switch0phy0>;
> -		};
> +&switch0port1 {
> +	label = "lan1";
> +};
>  
> -		switch0port3: port@3 {
> -			reg = <3>;
> -			label = "wan";
> -			phy-handle = <&switch0phy2>;
> -		};
> -	};
> +&switch0port3 {
> +	label = "wan";
>  };
>  
>  /* U11 */
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index b6f4af8ebafb..44dbe9a21cc7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -27,18 +27,10 @@ aliases {
>  	};
>  };
>  
> -&switch0 {
> -	ports {
> -		switch0port1: port@1 {
> -			reg = <1>;
> -			label = "lan1";
> -			phy-handle = <&switch0phy0>;
> -		};
> +&switch0port1 {
> +	label = "lan1";
> +};
>  
> -		switch0port3: port@3 {
> -			reg = <3>;
> -			label = "wan";
> -			phy-handle = <&switch0phy2>;
> -		};
> -	};
> +&switch0port3 {
> +	label = "wan";
>  };
> -- 
> 2.28.0
>