Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3986816pxk; Tue, 8 Sep 2020 07:54:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvMIWY3/6kOleYCfY5/uBk2ZV3hsu+VGFP6/ejCV46kumJejAOW3vYRwBBCgRy9UvrT/Ak X-Received: by 2002:a17:906:9591:: with SMTP id r17mr26955971ejx.424.1599576859143; Tue, 08 Sep 2020 07:54:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599576859; cv=none; d=google.com; s=arc-20160816; b=dBjwRkdzJQqRE3WSPpwzdTPYIw7sHAVxEVHpXrAJYCSRSaz4TNnNzvUl5B1H2Kllp4 hFWpAdOFW1QehCnnH0RtNcMA3FtP0MBF1yczGbCwCbLkdKcp34y8PuQlywPXWuxVuvua GiQgp10VI9+wZ7JJ+Yxf1795OwhUX8heTr2QRy8zVSvzgqX2tnjhu16RBsL1kr8sbclE ERKhXMttPYT6V2brW3qOZwJZyheDeMN+6hA46aQD718iwEbXeMiVBEoR3iKVClJDzhKR 1cXaZaMvDVtPLHVQAMrel8Ic4UB13Z/BIm+WvypO/h2navB06onto3rFpbwmsMveLnRl vsXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=djKbU2jcFBqmVYHTIVEf7ZKyWdVifVY08UeLjxtRsA0=; b=KkOUycvS7rwd+gjUAevxoxYJRMOFvWpAVh1LiNskdsgT2bLYwTGJJionNO9WqbfwOd V+fJ6iH0Y+cKI/xdRPTQKrxy5QF04f+FGusFwsls3NYtKLX5isr2VKnlqeZq3XF5Ft5E Np0i3tsRVnWwkGQSQvU7AG2EBjQAonlwYAPXBmhG/osQkZz6olSULbCA5BxtGXKjIDnO ue7fy8ZycEb7+PwRiZ4e1oCztQWkuWYWQpN1R32Hm+BcMpAKnvDUDMOtDFKoxglkgLR1 Ae0X0RrCkC5Tb4ZB/RQNsWJiflJkXqZT2uPC2a2z796LT/viCMVJEYwOKC7B6aL82t0H vDFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si4228525ejr.574.2020.09.08.07.53.56; Tue, 08 Sep 2020 07:54:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729576AbgIHOps (ORCPT + 99 others); Tue, 8 Sep 2020 10:45:48 -0400 Received: from mga18.intel.com ([134.134.136.126]:30643 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728957AbgIHO0J (ORCPT ); Tue, 8 Sep 2020 10:26:09 -0400 IronPort-SDR: DpD3qJR5vUlAYbi2fTQa+qKATfX/Hf4EXhkc0xyWXxuo4ht4w5jT6PJtiTV7Recj+oDV5gAkh+ YAFs9NumAfTg== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="145840843" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="145840843" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 06:56:27 -0700 IronPort-SDR: teJpYva7dmhExSNbTzHV8zh5qZlK7Qb63IZhY9bLtbpHc7vOZpnf08GckvTTKZVmfydKGskSeF gr5iJMG6ycMQ== X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="448793214" Received: from mgarber-mobl1.amr.corp.intel.com (HELO [10.212.179.134]) ([10.212.179.134]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 06:56:26 -0700 Subject: Re: [PATCH v2 3/4] soundwire: qcom: add support for mmio soundwire master devices To: Jonathan Marek , linux-arm-msm@vger.kernel.org Cc: "moderated list:SOUNDWIRE SUBSYSTEM" , open list , Bjorn Andersson , Vinod Koul , Andy Gross , Sanyog Kale , Bard Liao References: <20200905173905.16541-1-jonathan@marek.ca> <20200905173905.16541-4-jonathan@marek.ca> From: Pierre-Louis Bossart Message-ID: Date: Tue, 8 Sep 2020 08:56:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200905173905.16541-4-jonathan@marek.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -764,8 +786,11 @@ static int qcom_swrm_probe(struct platform_device *pdev) > if (!ctrl->regmap) > return -EINVAL; > } else { > - /* Only WCD based SoundWire controller is supported */ > - return -ENOTSUPP; > + ctrl->reg_read = qcom_swrm_cpu_reg_read; > + ctrl->reg_write = qcom_swrm_cpu_reg_write; > + ctrl->mmio = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(ctrl->mmio)) > + return PTR_ERR(ctrl->mmio); Shouldn't this be conditional on SLIMBUS being enabled, as done in your patch2? > } > > ctrl->irq = of_irq_get(dev->of_node, 0); >