Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Sep 2020 15:04:15 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     dillon.minfei@gmail.com
Cc:     linus.walleij@linaro.org, bgolaszewski@baylibre.com,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH: V2  2/2] gpio: tc35894: Disable Direct KBD interrupts to
 enable gpio irq
Message-ID: <20200908140415.GW4400@dell>
References: <1599118222-18990-1-git-send-email-dillon.minfei@gmail.com>
 <1599118222-18990-3-git-send-email-dillon.minfei@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1599118222-18990-3-git-send-email-dillon.minfei@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 03 Sep 2020, dillon.minfei@gmail.com wrote:

> From: dillon min <dillon.minfei@gmail.com>
> 
> On tc35894, have to disable direct keypad interrupts to make
> it as general purpose interrupts functionality work.
> if not, after chip reset, IRQST(0x91) will always 0x20,
> IRQN always low level, can't be clear.
> 
> Configure DIRECTx to enable general purpose gpio mode,
> else read GPIOMISx register always zero in irq routine.
> 
> verified on tc35894, need more test on other tc3589x.
> 
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
>  
> V1 -> V2:
> Add DIRECTx register configuration to active general purpose gpio mode.
> 
>  drivers/gpio/gpio-tc3589x.c | 18 ++++++++++++++++--

>  include/linux/mfd/tc3589x.h |  6 ++++++

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog