Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4077769pxk; Tue, 8 Sep 2020 10:05:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyl+PQFaI94wb5tsBlfb2UGTRQaAe0pRXFYLjbxy0Q0L9cCz2tajPBT1rIeoDkcCAsCynjW X-Received: by 2002:a50:bb65:: with SMTP id y92mr27823505ede.53.1599584724015; Tue, 08 Sep 2020 10:05:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599584724; cv=none; d=google.com; s=arc-20160816; b=nepSx1sjdHBdec+MfFxDRAI6B0gbP7TDtO2YYJQUA80zehk5X1JXXg88Eq22Q6JjSU Y1hZBX9/U2wfiGn2LF00NCljBLNzGY6GC1MlJh66EfJl2w4UYyQBjYKfSN9DnbFRZ+oM eNzRmNs/pdzeXbCPjH4B7MBb748YKzYzCRSgjaymLnThBImnkTw6Fd5h9zquwgvhoGvM zKGBtUNUBX2GPGsgF2nAVT5KfRoX/SqhZr0OtHjuQd7HN8W8sXNeenw/DjSpAG+B5JcO BO8lSxM5VoBP4AS0i1UhWAB+0iKsRlAvuREar7iCajNYVd6th+SahE661DFRXDmTp8bR tZIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=6r8oY7P5aaaNjTS2Z3JuHAo/BodSW0G0Qz3+9SCpdcA=; b=T98pvrkRffCzVCKAbj7/d9+ume53W3AwcCm+4a5Z8UU+Rd0cZdK2tEAc/+kHM/iElu JiEeTNGFFo4aECSbXfYj3dZpybRNQzQwErfBpa21LfyovCIMH0RGsGNmTGypxtd53Lrc 2xfGh9kUYl6zldJRr3Ntn1KNKCA7GzuEHNX7t9mW/FC2/hsoNFYEqK3R7PfVpSe9TCI2 OS3Q8ECm5ghgTie1KjVKOaMktnFyRDjixAV3Uvs8u/9EhUFwLEI1s4nmENNhzBgSchx7 U+EuAoHdiM1pRNLwzdkazcLJbX2cw4m5WYUIhoR5dgS0QWXxbTZSsoQMx/WiUEi2mUZ+ TMpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Fc5KlT/Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si3514093eje.690.2020.09.08.10.05.00; Tue, 08 Sep 2020 10:05:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Fc5KlT/Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731951AbgIHRDg (ORCPT + 99 others); Tue, 8 Sep 2020 13:03:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732038AbgIHRCv (ORCPT ); Tue, 8 Sep 2020 13:02:51 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A0C9C061756 for ; Tue, 8 Sep 2020 10:02:50 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id z25so55980iol.10 for ; Tue, 08 Sep 2020 10:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6r8oY7P5aaaNjTS2Z3JuHAo/BodSW0G0Qz3+9SCpdcA=; b=Fc5KlT/QgmDUw9wewiSXZGEfR0knpYXatiwTcFvCBfuTglDqwe97Xqfk0+3x8rqwqz +7tuFM8H7/+AmHKFAaAgiLJ6SRjQRhYk33odBKaz/HYiH3Ner4l978qk7J5fVRCppZat NzbCVkM8xF0xtOByqvqkwhwdQxGZyDDDgP822eVuJM4gG0Hcg8eiv1RslZap/Bek1+wl Zo6pLSrd6Y9goqQPOoDIZfkmRDiwu8LSP2FkQezPzvHh4k3BUYgvl+MCayPCGDN/ggRH EbcMddlY2Qg8dVmq7IG0F2iCUIwDUoScipcAw4Y7Ul6q0kcLqRY/IS7Ixd4PLxrKKOK1 TsFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6r8oY7P5aaaNjTS2Z3JuHAo/BodSW0G0Qz3+9SCpdcA=; b=e9Uvpk2W9vkCLz3AlQXCXnbtVZLGKOrlN5P+dXlg126jUfO5244YkgV5/1wAntYXVG ksITGZ5q1UxL6wXpdezhuW2RNoFOoiteX2nEO8w1qaEdIQ+9skkXxg9lOS6u7GlIOYCi HEYE0b9761WvuvlVHGPznVUJ10pJSWkfwUgNZ3IdHVSizY0IhF0nluMp9LAImPm9/UYG LsOlph5bYjvn974JX0m5naO8DX6hIMdMUGfGbil6MbOjDl5yAGTckstWS2FiATEGt2kX IQ0fexbelbm1kN/SWvgJRl0ttUp8pnwKK0CcB+nK9bKiXyV1DFHa/2LjpDtJ1FcQdAO9 phkA== X-Gm-Message-State: AOAM532fPaKQhvhg6u0gETxkJoh538R9iBif7oAIRQ0h031/y6HVhvJR U2dHZ0GX/drGgstQ0x2OK8VTiNARFDk6PmVd X-Received: by 2002:a02:9986:: with SMTP id a6mr23301374jal.28.1599584569815; Tue, 08 Sep 2020 10:02:49 -0700 (PDT) Received: from [192.168.1.10] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id i14sm10669430ilb.28.2020.09.08.10.02.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2020 10:02:49 -0700 (PDT) Subject: Re: [PATCH for-next] io_uring: return EBADFD when ring isn't in the right state To: Stefano Garzarella Cc: io-uring@vger.kernel.org, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200908165242.124957-1-sgarzare@redhat.com> From: Jens Axboe Message-ID: <6e119be3-d9a3-06ea-1c76-4201816dde46@kernel.dk> Date: Tue, 8 Sep 2020 11:02:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200908165242.124957-1-sgarzare@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/20 10:52 AM, Stefano Garzarella wrote: > This patch uniforms the returned error (EBADFD) when the ring state > (enabled/disabled) is not the expected one. > > The changes affect io_uring_enter() and io_uring_register() syscalls. I added a Fixes line: Fixes: 7ec3d1dd9378 ("io_uring: allow disabling rings during the creation") and applied it, thanks! > https://github.com/stefano-garzarella/liburing (branch: fix-disabled-ring-error) I'll check and pull that one too. -- Jens Axboe