Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4098811pxk; Tue, 8 Sep 2020 10:38:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybBCpeKRi7DOiqtmYepqWoaaNJLxjHemTZ5IZxamjfcf+F2nQAwY1a4id4/zBFE9neYPC4 X-Received: by 2002:a17:906:d8cd:: with SMTP id re13mr26423947ejb.140.1599586681483; Tue, 08 Sep 2020 10:38:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599586681; cv=none; d=google.com; s=arc-20160816; b=tHd5Rugkk7rwvtJFb92aPymxH0CmcDSiHsyeU1gIj7ANpav1kEfabW0Zsb9f9XMZm7 Z6ZHBkIYqT0h65ZwzUFHqHpmerWbco22INzEjCTVCGQyO/LE6Vu45nl8qjdMXsNeYXG+ VHl8xI7jd0d/BJDbUfN8uzGQaxI8MFQInOTh3jcJTJVUAw1XJqbnOcfdhP8Hebtsl9TM m7cgIWQQv2CwRbG1lTDE7nfn2D28mT2dyLxwECjWK1Gbkkd2UP8t84YZMVlBVmJPgK5Q OVJT0MLT+XweX872iBABTcDdOfrBhRDkT2WXa9yCEXvy0m+ndL1o8X9M7Ef9myijb7Ra ep1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Vrj3035BsDcdrz0VpAXQtCkSg5zN1Pm7pcoGPlszHkk=; b=OAC05Q1P58/fQOyvcEVkjyrKhqw8EqhnqZCHgXlcgAr6LtObyuYRHJsdmgkz4CJmTr WeoS8DeJSj2XXu8JkssCJQL1HJUYeIP2nau8AdkTj5o4udvvoDUH2S2NzkE0iDoA/uvZ MFg/DmIWOjRpON76u4WKD8ntPiRG5XTKncnzEFgnpGCXUDiVv/mp1Fy3adIgSA29x+zO +uAlFQUDpWC8erEO6siMjUPieIuUhRi4qknUZMkrudK142oz8ZvExP2ilarqxrV+l5QH /gKHmAFiEHSbs8uFYcs+FJ0fVFHK85g/ldeCgXe9PAYhlaNYHfKCbjc1bVKw4MSHTpiN dmFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=YDxIuM6l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k24si12907354eja.436.2020.09.08.10.37.38; Tue, 08 Sep 2020 10:38:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=YDxIuM6l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731162AbgIHRhE (ORCPT + 99 others); Tue, 8 Sep 2020 13:37:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731835AbgIHRg7 (ORCPT ); Tue, 8 Sep 2020 13:36:59 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8128EC061573 for ; Tue, 8 Sep 2020 10:36:58 -0700 (PDT) Received: from zn.tnic (p200300ec2f10bf0070b09dfd4356f225.dip0.t-ipconnect.de [IPv6:2003:ec:2f10:bf00:70b0:9dfd:4356:f225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DFA881EC0489; Tue, 8 Sep 2020 19:36:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1599586617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Vrj3035BsDcdrz0VpAXQtCkSg5zN1Pm7pcoGPlszHkk=; b=YDxIuM6lZ+gB0DKwdbm9IwN7GvlMIKA5A3+upt1bsXJzCzj74ffgVcZNn11kQwlT8julbg QvO7lMl2HokGbuwr5v1b7J0/Fk0Yh/bBUCl8QWO444YR7wRPRVXVSAGzYYCodTiyjEbvYl JULC6n0O2JfAFH53ngqQrD2NJCme2iY= Date: Tue, 8 Sep 2020 19:36:56 +0200 From: Borislav Petkov To: "Jason A. Donenfeld" Cc: Srinivas Pandruvada , kitsunyan , "Brown, Len" , X86 ML , LKML , Linus Torvalds , Sultan Alsawaf Subject: Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX Message-ID: <20200908173656.GI25236@zn.tnic> References: <20200907094843.1949-1-Jason@zx2c4.com> <20200907100647.GB10657@zn.tnic> <22617e57e541e460fac09db04fdb370f8e96e8ef.camel@linux.intel.com> <20200908172558.GG25236@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2020 at 07:29:11PM +0200, Jason A. Donenfeld wrote: > Well that's not cool. So you're saying that if someone wants to kill its box by poking at that MSR, we should just let her/him? If anything, I think that a BIG FAT WARNING at least would make sense. Now, if there were a proper interface which would allow only valid commands, now that would be optimal... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette