Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4103387pxk; Tue, 8 Sep 2020 10:45:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzn/CIo9kGlkGNiwHFpyBOtQCFvhA8qBONdaSuC3JZTm6B4Azp5TD8MdCYmr9+5A0L4OM3L X-Received: by 2002:aa7:cb8f:: with SMTP id r15mr90337edt.356.1599587156222; Tue, 08 Sep 2020 10:45:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599587156; cv=none; d=google.com; s=arc-20160816; b=ScTKOqAq1qC09+tH9jAOD/0ezP/OddU7qUfd2QT9NnnScsxT2hcjNa91Uhh10FZ3/j Xv5j/aYRlqkhDWFQSUVlzR3rqvATPa30xMArNhnk/aBwY9czhVhupbiEZ0SOGm04eTu9 eFv77h7QQEtFRtB3V8qloCpKZJdTwtrXA0tY/WVu2QX3z3Gx93aPjvOPb+VJapqfwE1P 3Qi9/p05S3z2DiB/93wcf9N05njd2p/DLpXWc7EU2NqQLZcrZDqUthbIXef6MAtuqX+o h/+KE+fu+zBeZjs19XwckwjD7fDz3Qty0CwSKbSxGufX5NVGiI9TPzdV5ipXjR+mySYX Ho0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=dZuA6h9Sn+JjFDEYLxGqsKWwWg8xIOU7Tu+DodINjXU=; b=NJOQQkfBstyKjOG8aaUImn4zXpvBRydgl4hYAodby7vqV3rJJ8xWc1jqvVIBUc0KiD w2mLKtbBQM+Y+82CuW0N7nKG1x8L9kktzbxMihVoh5LOUYWH1ocePvPEDThmWBZrjfoG iBK4AK26rXcIZffPhrU7RtOcwD6+JecYZNfU/rAhF+cOuHPoHVekyj54BPKOxf/Uvpql OuuA2KaNLI99cZnE6dJ0GChX22Gd7owQrs89K13fdi5tfPTm7pbTgGIaO7WNKpkEGk2l PNZg4jXv1Dlwt71aplhYct127ViPhO9m4qrWVehl3u6AvQRMMf7OE/xW4YswlT/bAL1/ J+oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b="140/DSYG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e18si12368160edv.524.2020.09.08.10.45.33; Tue, 08 Sep 2020 10:45:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b="140/DSYG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731995AbgIHRm6 (ORCPT + 99 others); Tue, 8 Sep 2020 13:42:58 -0400 Received: from mail.zx2c4.com ([192.95.5.64]:36701 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731663AbgIHRm2 (ORCPT ); Tue, 8 Sep 2020 13:42:28 -0400 Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 832e0821 for ; Tue, 8 Sep 2020 17:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=O1y/MP6BAJBcGK9O2C6twcvboJc=; b=140/DS YGC+zc+6THM1gigQAIcITIcZPrYWw0mr27ZP56zdy8kKFccpokpzcb9/syJquCfo uH0hYSXNTeNk5WKbZe18I0qvdXFOOIWxnx24bgXvfroORab3d+93a8ijLYpjoUTd jz+Lg7evjS7RzZuQhVMy0biNFXUM1U6MYWR6KfMT+hIUjqqeiCBR1v6w7i5vUHdQ xBTWCkvHnrmmHM7tFs3b9BCvoY70F8Ltqc4A7LL/z6i9I04pMUYzyheA0K7XSVwt 3IL4DpC9E1+CpwBv6IRsoQpubc/DMRmHJ6gIrqhtIdrFErpqVco6FI/e0zplk+Rl TbmeK5VQYXGstP0A== Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 438e7a61 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 8 Sep 2020 17:13:30 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id m17so262366ioo.1 for ; Tue, 08 Sep 2020 10:42:24 -0700 (PDT) X-Gm-Message-State: AOAM530F/p4r/Z3YB0ZlIp8gFtMZFLS698daJ2zdkDbWKGKc8clXl6WJ 8aLnvc8fy6A4M1n/Nq6rA7J07tM3oy/5yWuT5dI= X-Received: by 2002:a6b:7112:: with SMTP id q18mr21480718iog.79.1599586943669; Tue, 08 Sep 2020 10:42:23 -0700 (PDT) MIME-Version: 1.0 References: <20200907094843.1949-1-Jason@zx2c4.com> <20200907100647.GB10657@zn.tnic> <22617e57e541e460fac09db04fdb370f8e96e8ef.camel@linux.intel.com> <20200908172558.GG25236@zn.tnic> <20200908173656.GI25236@zn.tnic> In-Reply-To: <20200908173656.GI25236@zn.tnic> From: "Jason A. Donenfeld" Date: Tue, 8 Sep 2020 19:42:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX To: Borislav Petkov Cc: Srinivas Pandruvada , kitsunyan , "Brown, Len" , X86 ML , LKML , Linus Torvalds , Sultan Alsawaf Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 8, 2020 at 7:36 PM Borislav Petkov wrote: > > On Tue, Sep 08, 2020 at 07:29:11PM +0200, Jason A. Donenfeld wrote: > > Well that's not cool. > > So you're saying that if someone wants to kill its box by poking at that > MSR, we should just let her/him? > > If anything, I think that a BIG FAT WARNING at least would make sense. Are you prepared to track down all the MSRs that might maybe do something naughty? After determining optimal voltages, people have systemd running intel-undervolt for them. It becomes part of the normal system configuration, is applied all the time, and after figuring it out once, users forget they ever had enabled it, except when observing that their laptop works better than it originally did. Does `dd` warn when you run `dd if=/dev/zero of=/dev/sda`? > Now, if there were a proper interface which would allow only valid > commands, now that would be optimal... Probably not possible. Optimal values are related to the "silicon lottery" that occurs when you buy a new CPU. Different optimal values for different individual chips.