Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4116359pxk; Tue, 8 Sep 2020 11:06:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqD0TPNaCmah/M7a/mAbKCn3MHGlLtfDrLauyiC1JokvK5ZszMCbcC2E+eQr9QDGXN7DHN X-Received: by 2002:a17:906:2818:: with SMTP id r24mr14236934ejc.100.1599588391401; Tue, 08 Sep 2020 11:06:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599588391; cv=none; d=google.com; s=arc-20160816; b=cxikOpATimwj+QseQwZyi/VpCcYJ0s9WsA8i3tyaFbe/2GbcZ95UHp/YuPUp1h4PWs 7o3LgeotKV34VF63EBgBLfHyobzCoELmPjlMMLDRHa6ka89QV2ouLUM0A4hl08ltbhvo mIX1hUgq/quhBF4GLYpmcBrASGcdQh6uqgAF6R/VioVsfa5+Ntb/W+AddYPWP0h+m1Us 1hs+v2Q/1VqpCGdlZsqEJG8ap5VJUAzrlICFuuthnKVFoMGgLhRKDT7Xvuz3R6gTzfBz MGY+jrOZG4mUcnACSKtPi7LJpzJKY0o9aTAvbiRvBtT7jSVilShI3BsobN/GY6puXPlP eLBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6F160vRQD3gy8kEWpdgbTnaQrQA/B5sWDpFommPRh3A=; b=m2K//GfhvY5wOnK2Mee3JW3SNhLlXEeiA392Op8bSpX5giUvIZJIZ8EGEij4aqeqIa sRvRBdUE7ttB02lTdET+L1k6x6z9OBK8zv8lPDmSrLG6D37M5PpM+BUXO5v3LWfyNN6w zapRNbj0e6K084LjoAvbqTN/iLtQOdU01G6eOYuVwaDpHvqzzKBJN8eaoT8MCkM+PvVS gEWMzKQxx1+2XLM0NPej6Oc9rGVpMHvO2Xl2R8kkSqT/9Yg+oqksfCfum+63SkyIa5U2 CtLioGwBxhJji8QU/WEXvzwOI5OXbmo9vZ8EDqXNCKF9Opxa59bOAR+1i4eU4swL6d6g ziiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EYyGvGZT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lf11si12462795ejb.48.2020.09.08.11.06.09; Tue, 08 Sep 2020 11:06:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EYyGvGZT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731836AbgIHSA5 (ORCPT + 99 others); Tue, 8 Sep 2020 14:00:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:56080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731533AbgIHQMM (ORCPT ); Tue, 8 Sep 2020 12:12:12 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E4B1247D6; Tue, 8 Sep 2020 15:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599580293; bh=vQ8XEpwc50stmnvkX4zSfdoub4klCXtqsUrmoDbVrO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EYyGvGZTFV+tkbFNQ8BRNIPvaaAHo8BTZw1U1CpvmUGq8itXKK6gAGztUrjBJvKVv oHXBxBY2R87veBcBeUvlVChxvTqWRvm9uvUYmuuhLa97vXbVrRDKGc1hs5stOje44U lI0wHhyT39XJBg0tiOEtjgSB+JWBH22T+GZFfeSA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Layton , Ilya Dryomov , Sasha Levin Subject: [PATCH 4.14 07/65] ceph: dont allow setlease on cephfs Date: Tue, 8 Sep 2020 17:25:52 +0200 Message-Id: <20200908152217.403651735@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200908152217.022816723@linuxfoundation.org> References: <20200908152217.022816723@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Layton [ Upstream commit 496ceaf12432b3d136dcdec48424312e71359ea7 ] Leases don't currently work correctly on kcephfs, as they are not broken when caps are revoked. They could eventually be implemented similarly to how we did them in libcephfs, but for now don't allow them. [ idryomov: no need for simple_nosetlease() in ceph_dir_fops and ceph_snapdir_fops ] Signed-off-by: Jeff Layton Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 6d653235e323b..1f873034f4691 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -1728,6 +1728,7 @@ const struct file_operations ceph_file_fops = { .mmap = ceph_mmap, .fsync = ceph_fsync, .lock = ceph_lock, + .setlease = simple_nosetlease, .flock = ceph_flock, .splice_read = generic_file_splice_read, .splice_write = iter_file_splice_write, -- 2.25.1