Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1599536678-4666-1-git-send-email-mansur@codeaurora.org>
References: <1599536678-4666-1-git-send-email-mansur@codeaurora.org>
Subject: Re: [PATCH 2/2] venus: core: vote for video-mem icc path and change avg, peak bw
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        vgarodia@codeaurora.org,
        Mansur Alisha Shaik <mansur@codeaurora.org>
To:     Mansur Alisha Shaik <mansur@codeaurora.org>,
        linux-media@vger.kernel.org, stanimir.varbanov@linaro.org
Date:   Tue, 08 Sep 2020 11:38:17 -0700
Message-ID: <159959029779.454335.10674172341529908104@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Mansur Alisha Shaik (2020-09-07 20:44:38)
> Currently we are voting for venus0-ebi path during buffer processing
> with an average bandwidth of all the instances and unvoting during
> session release.
>=20
> While video streaming when we try to do XO-SD using the command
> "echo mem > /sys/power/state command" , device is not entering
> to suspend state and from interconnect summary seeing votes for venus0-ebi
>=20
> Corrected this by voting for venus0-ebi path in venus_runtime_resume

venus_runtime_resume() please so we know it's a function.

> and unvote during venus_runtime_suspend.

venus_runtime_suspend().

>=20
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> ---

Any Fixes: tag?

>  drivers/media/platform/qcom/venus/core.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/pla=
tform/qcom/venus/core.c
> index 4857bbd..79d8600 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -373,6 +373,10 @@ static __maybe_unused int venus_runtime_suspend(stru=
ct device *dev)
>         if (ret)
>                 return ret;
> =20
> +       ret =3D icc_set_bw(core->video_path, 0, 0);
> +       if (ret)
> +               return ret;
> +
>         return ret;
>  }
> =20
> @@ -382,7 +386,11 @@ static __maybe_unused int venus_runtime_resume(struc=
t device *dev)
>         const struct venus_pm_ops *pm_ops =3D core->pm_ops;
>         int ret;
> =20
> -       ret =3D icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000));
> +       ret =3D icc_set_bw(core->video_path, kbps_to_icc(20000), 0);

This also shows that the arguments to icc_set_bw() we're backwards? Can
that be fixed in another patch instead of putting it in this one?