Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kees Cook <keescook@chromium.org>
To:     Tycho Andersen <tycho@tycho.pizza>
Cc:     Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Christian Brauner <christian@brauner.io>
Subject: Re: [PATCH] seccomp: don't leave dangling ->notif if file allocation fails
Date:   Tue,  8 Sep 2020 11:41:54 -0700
Message-Id: <159959050861.1264035.3217861807726166263.b4-ty@chromium.org>
In-Reply-To: <20200902140953.1201956-1-tycho@tycho.pizza>
References: <20200902140953.1201956-1-tycho@tycho.pizza>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2 Sep 2020 08:09:53 -0600, Tycho Andersen wrote:
> Christian and Kees both pointed out that this is a bit sloppy to open-code
> both places, and Christian points out that we leave a dangling pointer to
> ->notif if file allocation fails. Since we check ->notif for null in order
> to determine if it's ok to install a filter, this means people won't be
> able to install a filter if the file allocation fails for some reason, even
> if they subsequently should be able to.
> 
> [...]

Applied, thanks!

[1/1] seccomp: don't leave dangling ->notif if file allocation fails
      https://git.kernel.org/kees/c/e839317900e9

as featured on my Twitch stream! ;)

-- 
Kees Cook