Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: JxtOrhEL2IN2nLZOWwzpucfgbW84Q++ZSiPAB3+UEZGu3N+qTLnTnv7KiaeIdXtHSt1qdsrriC
 W4ZycAUl4mFg==
IronPort-SDR: Y633VkXYeLItp/BiYFQLWnOuVpA1lx6LudGy6mO47pEFOy6pTpuzXaoEMrsUUnhOE4kG4Og2or
 Ab2bATFPLVkQ==
Subject: Re: [PATCH v1] x86/defconfigs: Unbreak 32-bit defconfig builds
To:     Ingo Molnar <mingo@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>
References: <20200908100018.50188-1-andriy.shevchenko@linux.intel.com>
 <20200908121354.GA3848343@gmail.com>
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
Message-ID: <7424b868-7463-2ea4-1cb0-386b143dc8f0@linux.intel.com>
Date:   Tue, 8 Sep 2020 16:49:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200908121354.GA3848343@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi

On 9/8/20 3:13 PM, Ingo Molnar wrote:
> 
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
>> After the commit 1d0e12fd3a84 ("x86/defconfigs: Refresh defconfig files")
>> 32-bit builds using defconfig become broken because on x86_64 build host
>> with no ARCH provided the default behaviour is to assume 64-bit independently
>> on the configuration file name. The crucial part is CONFIG_64BIT option
>> that used to be explicit. Let restore the latter option in order to unbreak
>> 32-bit builds.
> 
> So exactly which build method broke due to this? The typical way to do a defconfig build is:
> 
>    make ARCH=i386 defconfig
> 
> which still works fine AFAICS.
> 
Maybe wrong way to do it, just plain "make i386_defconfig". I'm aware of 
ARCH=, but never needed to specify it for x86 targets.

Jarkko