Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4176209pxk; Tue, 8 Sep 2020 12:39:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHhwkYurOU/vsVX33GMAkmOriZXtRKPuFBN7Q3jqqmI+OSM/JldnupDGBoTQvugwvSz9r9 X-Received: by 2002:aa7:d353:: with SMTP id m19mr577368edr.275.1599593974966; Tue, 08 Sep 2020 12:39:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599593974; cv=none; d=google.com; s=arc-20160816; b=e0eZhLLY7qxwQEbXclZgn6/TOy4Yv0PzoROLNH1nE6avJ8Bu3P3U14WZhA4EcgG9oV EAVG54TqiqGQTICBv+6/EGgI9LboN2fA6YRAA0tTKSU29AnWr0RNUhdMqgbYYtftyJtv OVgBcXgdpAk20j8s9D9LhWQCYKQogQber3IYR9b2bjHvz670HYklMNebHJqrmoaFn6vc URhTyZYYxMDd8jW40tZKMUdPue9bTf4Jr289Td/YdZ6H6wSMwQkx5wCt5HphyBqjMoko VuXf7K9XwI7sr0M3KgTrrEcvjM0FZQPl0DoWEbRZIXYaLWotPILPXNWv6qOmNxgt579D mBOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NfYkZqMIYJWE0D6hAZLp/L+b7/9lJ1uqdfG5LMXNgTI=; b=gw5HPymm2wgr0y/f+uyMs8BZgYSFuoiyb7/TqzUc4m/kApYsc3WwBLYDrQikrGkIrB zmI5Tmon4bOV9htrSMDIn6G/XCkt/Vtl5rPb2kvKElMDI1GlnO48wQN0ECsSwYlajt7+ Gewt7DT02Bd8CFdxDOOx+Vj8n6QUZOLsBqAfj4Ew49cAO3hYBTHDabo5i34kxLyyVk+F fl4I2h0VT3IhdvE6Hg1A27pl1ak4uO08Q213cqSE8Vx/SUBCzk1BFguzPYsTXFDKXezY OcneR+J/sk9lXssomi2I0ZZCClIJ57TtCHNAofYer8ps07qRJ/YSfGdUO4LlLRXpJGnS lHyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j7xh1mez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si54844eds.225.2020.09.08.12.39.12; Tue, 08 Sep 2020 12:39:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j7xh1mez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732208AbgIHThT (ORCPT + 99 others); Tue, 8 Sep 2020 15:37:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730975AbgIHP4x (ORCPT ); Tue, 8 Sep 2020 11:56:53 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7039FC061A20 for ; Tue, 8 Sep 2020 08:29:57 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id jw11so2311439pjb.0 for ; Tue, 08 Sep 2020 08:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NfYkZqMIYJWE0D6hAZLp/L+b7/9lJ1uqdfG5LMXNgTI=; b=j7xh1mezDjKnq8jlEyx3H7PuoKGQjIYYsw35I2dMoIM1UN9WYzIjFvAn03GXXuq9yJ mqhaMLnzZT38dHrvFh+bK60nqJ/8lpK15o+FGGp+4i2JqPBztH9gy1AtLWpd5GTs63T3 n9+m9g3wrBRCi9s3EuhzbkZkrvLTU1GQBmyhB9jwGAHGyIEMUCwOQAwxjxt+ncA7Hp+i MUGb3ghi19LyECNbZeYA5fh311uFHZNyRgajh3nuFepjp4xfUzVfKeXJkU6HiR4QAAZQ emdqELmuOR1N0AnYwTsV2PpATECgkYBSgk+7ONtkvWJew8lQh/RusK6saWuItXajVSit JiaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NfYkZqMIYJWE0D6hAZLp/L+b7/9lJ1uqdfG5LMXNgTI=; b=efH6FvymGAryVsl330KeQOYxCILNd1VZwBSWM/f1+1sJ37v4Iapb2kA/F6keiy0CjV dEHT6ht1OPW/VTwLJpcpILflaOTp2vpOtqky2Pd/YqoeNM3Sj79qglTWFP9WqkwEHEhl StrsKziDfFHg1wJ/OZBF/KsDwUrqa4xVgNDVXFMGfTGKJxotoIXu5SkPVbviR/qiZQyz HmflDiuzYMc0seG0NsBALxPsaNfHB92nxbJT6ZoPtzXiWoK83af6sOkqRffEnzkfJqvV 7sRi2WqEQfgJeyhsS7JsoJt2SRN8XuYMyxVosURuxAqgq2x0ZFRqBJlNmZO7O6v/vKfz q1CQ== X-Gm-Message-State: AOAM5322Ba6Zj1a2tqi+yQVLmWLEfMmV+bT3xtTOfYYhn5PfOWgF6LUA Bj3KAld2219ZNFpwZGB5Zjng X-Received: by 2002:a17:90a:fe04:: with SMTP id ck4mr4687810pjb.210.1599578996799; Tue, 08 Sep 2020 08:29:56 -0700 (PDT) Received: from mani-NUC7i5DNKE ([2409:4072:6213:6149:94b7:eeb3:82a5:2b53]) by smtp.gmail.com with ESMTPSA id c199sm19091498pfc.128.2020.09.08.08.29.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Sep 2020 08:29:56 -0700 (PDT) Date: Tue, 8 Sep 2020 20:59:47 +0530 From: Manivannan Sadhasivam To: Bjorn Andersson Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, robh+dt@kernel.org, agross@kernel.org, amitk@kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmitry.baryshkov@linaro.org, tdas@codeaurora.org Subject: Re: [PATCH 6/7] cpufreq: qcom-hw: Add cpufreq support for SM8250 SoC Message-ID: <20200908152926.GD2352@mani-NUC7i5DNKE> References: <20200908075716.30357-1-manivannan.sadhasivam@linaro.org> <20200908075716.30357-7-manivannan.sadhasivam@linaro.org> <20200908152217.GO3715@yoga> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200908152217.GO3715@yoga> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 0908, Bjorn Andersson wrote: > On Tue 08 Sep 02:57 CDT 2020, Manivannan Sadhasivam wrote: > > > SM8250 SoC uses EPSS block for carrying out the cpufreq duties. Hence, add > > support for it in the driver with relevant of_match data. > > > > Signed-off-by: Manivannan Sadhasivam > > Reviewed-by: Bjorn Andersson > > > --- > > drivers/cpufreq/qcom-cpufreq-hw.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c > > index de816bcafd33..c3c397cc3dc6 100644 > > --- a/drivers/cpufreq/qcom-cpufreq-hw.c > > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c > > @@ -285,8 +285,17 @@ static const struct qcom_cpufreq_soc_data qcom_soc_data = { > > .lut_row_size = 32, > > }; > > > > +static const struct qcom_cpufreq_soc_data sm8250_soc_data = { > > Could it be that this is the "epss_soc_data" (i.e. not sm8250 specific)? > (We should still use/include the platform specific compatible though). > Hmm, makes sense. Will change it. Thanks, Mani > Regards, > Bjorn > > > + .reg_enable = 0x0, > > + .reg_freq_lut = 0x100, > > + .reg_volt_lut = 0x200, > > + .reg_perf_state = 0x320, > > + .lut_row_size = 4, > > +}; > > + > > static const struct of_device_id qcom_cpufreq_hw_match[] = { > > { .compatible = "qcom,cpufreq-hw", .data = &qcom_soc_data }, > > + { .compatible = "qcom,sm8250-epss", .data = &sm8250_soc_data }, > > {} > > }; > > MODULE_DEVICE_TABLE(of, qcom_cpufreq_hw_match); > > -- > > 2.17.1 > >