Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
CC:     Roman Gushchin <guro@fb.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>, <linux-mm@kvack.org>,
        Rik van Riel <riel@surriel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Shakeel Butt <shakeelb@google.com>,
        Yang Shi <yang.shi@linux.alibaba.com>,
        David Nellans <dnellans@nvidia.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 00/16] 1GB THP support on x86_64
Date:   Tue, 8 Sep 2020 10:05:11 -0400
Message-ID: <7E20392E-5ED7-4C22-9555-F3BAABF3CBE9@nvidia.com>
In-Reply-To: <8e677ead-206d-08dd-d73e-569bd3803e3b@redhat.com>
References: <20200902180628.4052244-1-zi.yan@sent.com>
 <20200903142300.bjq2um5y5nwocvar@box>
 <20200903163020.GG60440@carbon.dhcp.thefacebook.com>
 <8e677ead-206d-08dd-d73e-569bd3803e3b@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed;
        boundary="=_MailMate_90CC73A7-32C1-445F-AAA5-E7CCB35F7A6C_=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=_MailMate_90CC73A7-32C1-445F-AAA5-E7CCB35F7A6C_=
Content-Type: text/plain; charset="UTF-8"; markup=markdown
Content-Transfer-Encoding: quoted-printable

On 8 Sep 2020, at 7:57, David Hildenbrand wrote:

> On 03.09.20 18:30, Roman Gushchin wrote:
>> On Thu, Sep 03, 2020 at 05:23:00PM +0300, Kirill A. Shutemov wrote:
>>> On Wed, Sep 02, 2020 at 02:06:12PM -0400, Zi Yan wrote:
>>>> From: Zi Yan <ziy@nvidia.com>
>>>>
>>>> Hi all,
>>>>
>>>> This patchset adds support for 1GB THP on x86_64. It is on top of
>>>> v5.9-rc2-mmots-2020-08-25-21-13.
>>>>
>>>> 1GB THP is more flexible for reducing translation overhead and incre=
asing the
>>>> performance of applications with large memory footprint without appl=
ication
>>>> changes compared to hugetlb.
>>>
>>> This statement needs a lot of justification. I don't see 1GB THP as v=
iable
>>> for any workload. Opportunistic 1GB allocation is very questionable
>>> strategy.
>>
>> Hello, Kirill!
>>
>> I share your skepticism about opportunistic 1 GB allocations, however =
it might be useful
>> if backed by an madvise() annotations from userspace application. In t=
his case,
>> 1 GB THPs might be an alternative to 1 GB hugetlbfs pages, but with a =
more convenient
>> interface.
>
> I have concerns if we would silently use 1~GB THPs in most scenarios
> where be would have used 2~MB THP. I'd appreciate a trigger to
> explicitly enable that - MADV_HUGEPAGE is not sufficient because some
> applications relying on that assume that the THP size will be 2~MB
> (especially, if you want sparse, large VMAs).

This patchset is not intended to silently use 1GB THP in place of 2MB THP=
=2E
First of all, there is a knob /sys/kernel/mm/transparent_hugepage/enable_=
1GB
to enable 1GB THP explicitly. Also, 1GB THP is allocated from a reserved =
CMA
region (although I had alloc_contig_pages as a fallback, which can be rem=
oved
in next version), so users need to add hugepage_cma=3DnG kernel parameter=
 to
enable 1GB THP allocation. If a finer control is necessary, we can add
a new MADV_HUGEPAGE_1GB for 1GB THP.


=E2=80=94
Best Regards,
Yan Zi

--=_MailMate_90CC73A7-32C1-445F-AAA5-E7CCB35F7A6C_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl9Xj5cPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKiFgP/2j/lRwfL410/Fcmx92+Cm4VFsGln6IyW0bn
yBSO/B6CqjIZBcxLkbUHy1mfCAAT+y+p2JLyNyCF7AY00yVTiyQdtPtbuA61vAWB
SZQkKEA1iOCN758VrDxsjF724WyWvnfPR5eGAAiYKvAaU/j8/nhE/UgRVq8JyCHn
KtK/1D9V2ud+XnT05HZusqmhG0o/1ejsJjMVoxWOuNfrf4ZjDZC325s/WRBbKhLc
4lNElDUvOndvG+yy+f0DbNzYFSeU47y4N8y+WIhUyeNUBL3zpPuY74eoZ1awl4mN
a4DDL8aU1GWgeuNTTQzxzMJd90mvJns2GRf1btNKlzWZYCj8LrZGXZ6aonp14TIh
3RfkOKkz9k2OQkm7j3HpSg/pp6T+IcEVuid296hQcumaeRCQSCS8IhERve2WxBeB
tgVMfwXLkaMuENmXLgMTtUjvOJSvJvvZTovc2KJibyOXWTBqCpX5l5p0YElw2ZK3
GrTZMEaIvtJ3BksM2aLfLygMQfgFUMm+e2qtxRKQFD/TEZI/cwNK6aSL46qey0OU
VFGXvnRCvzMS9gggT0yTTcVkbfNgRzrk5J3Jj6wPqckpgpHiciZTrs1Z/dj3gn73
mNpwfpD2qdLiZpLEubiuPX0p/ixSsZzWXA1ByyWyLBNS9bv3bmOt15HarDD9+Pga
xzn2iS/U
=5FkR
-----END PGP SIGNATURE-----

--=_MailMate_90CC73A7-32C1-445F-AAA5-E7CCB35F7A6C_=--