Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4187205pxk; Tue, 8 Sep 2020 13:00:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6hldCuCx3D7AkKiTY1kryzCgwblKh8sfkMioXKg6fDaM+ZhxHsmkU7o5jHHfe/XnD08c/ X-Received: by 2002:a17:906:95d1:: with SMTP id n17mr125761ejy.324.1599595217037; Tue, 08 Sep 2020 13:00:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599595217; cv=none; d=google.com; s=arc-20160816; b=ZacCKk1xjOeYQMyU1ZYjR3u5U6JNrYIuqgF+OaFGKZQMBiodIlvVTKcRpPg9o63lry FdnLOwEoJLTwpOx1zoqGsqQOUlx5v6xdntUBTKZ7ouiWPDGeegtwMEuHHLn8NIYvKz2p LynNjq/Py3DxPT6X+u2h9cr48igJ6+nvPUxX1D6O+PZwo/gdpdBCJVBbIMSuB1NS8w/t /ydLPTyA0brABU/GBBDQPouOggWcIPUyNQZ2rWWW232uaPZ23TyC2jIW6IswARHjbZ3X QzJ5KTaOsDxjvu2XfkoZg36TLLm8/yenCjOmstErBVGUVjBiAo6PQ2HcfIhRexAYOmmE UStg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dCLPFbReHiP+GUvMcNJ/RFf15SMWX3RH9dwLhDo19y0=; b=hTqs8jupY/ckH1Fhrw4WSkrux8OcpgdkqB4PqUPbD/Rl1lu7afvXSb+hHnEYt4UgN7 d62jYEqokgFUkqBZtbHPQtmmK8EhAxZQ/1WFMLBIZek8l8yNqCGnBoc/ykmZ29+DrV6X 2mYEu2IgS37JrzlfG0gmtL6mveOz/ZoovO4OcdJDHQFVBSbPvsjq77NjTISF1AVcKZMA PchHIrqp4aexeVTLBGrjLLDtvOOZ9Iq/pJ6SEOA2W0G/5FZ9DWbYUqhaLjfhVPevARw6 OrCaBRmmTP3xmu5vTQRWM/cckYFQzfVp1Axs9D1vzYCpYh48SAVM7x6MraqrIqk2lo0G cNwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f2eGpcpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id wq13si4125ejb.722.2020.09.08.12.59.53; Tue, 08 Sep 2020 13:00:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f2eGpcpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732526AbgIHT5M (ORCPT + 99 others); Tue, 8 Sep 2020 15:57:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:58866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730395AbgIHPfu (ORCPT ); Tue, 8 Sep 2020 11:35:50 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E23D224DF; Tue, 8 Sep 2020 15:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599579304; bh=0vtMZTzu1NrMLLIC1iLpFv/vqWhtJrj/0g35C6ArFy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f2eGpcpywsmwLob4ix25t5dDnw3RX9f/39gmGVU/BMi/hsU7ol0rUUBQlWXCbsp8J KALpvP4bFJY6xA5W1HAcxuvZsXhPya5BtC5MpNVk3rx89TBCAQ8JIdmXm1SdAtZMwD awxu+BPOElm9p1LsJyvOzDo6jdGNjJYaP96kEBk4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Layton , Ilya Dryomov , Sasha Levin Subject: [PATCH 5.8 022/186] ceph: dont allow setlease on cephfs Date: Tue, 8 Sep 2020 17:22:44 +0200 Message-Id: <20200908152242.732686168@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200908152241.646390211@linuxfoundation.org> References: <20200908152241.646390211@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Layton [ Upstream commit 496ceaf12432b3d136dcdec48424312e71359ea7 ] Leases don't currently work correctly on kcephfs, as they are not broken when caps are revoked. They could eventually be implemented similarly to how we did them in libcephfs, but for now don't allow them. [ idryomov: no need for simple_nosetlease() in ceph_dir_fops and ceph_snapdir_fops ] Signed-off-by: Jeff Layton Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index d51c3f2fdca02..327649883ec7c 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -2507,6 +2507,7 @@ const struct file_operations ceph_file_fops = { .mmap = ceph_mmap, .fsync = ceph_fsync, .lock = ceph_lock, + .setlease = simple_nosetlease, .flock = ceph_flock, .splice_read = generic_file_splice_read, .splice_write = iter_file_splice_write, -- 2.25.1