Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     Michal Hocko <mhocko@suse.com>
CC:     Roman Gushchin <guro@fb.com>, <linux-mm@kvack.org>,
        Rik van Riel <riel@surriel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Shakeel Butt <shakeelb@google.com>,
        Yang Shi <yang.shi@linux.alibaba.com>,
        David Nellans <dnellans@nvidia.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 00/16] 1GB THP support on x86_64
Date:   Tue, 8 Sep 2020 11:09:25 -0400
Message-ID: <3CDAD67E-23A1-4D84-BF19-FFE1CF956779@nvidia.com>
In-Reply-To: <20200907072014.GD30144@dhcp22.suse.cz>
References: <20200902180628.4052244-1-zi.yan@sent.com>
 <20200903073254.GP4617@dhcp22.suse.cz>
 <20200903162527.GF60440@carbon.dhcp.thefacebook.com>
 <20200904074207.GC15277@dhcp22.suse.cz>
 <20200904211045.GA567128@carbon.DHCP.thefacebook.com>
 <20200907072014.GD30144@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: multipart/signed;
        boundary="=_MailMate_7EDFBC1A-C6C8-4AEF-8110-676C99F27B91_=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=_MailMate_7EDFBC1A-C6C8-4AEF-8110-676C99F27B91_=
Content-Type: text/plain; charset="UTF-8"; markup=markdown
Content-Transfer-Encoding: quoted-printable

On 7 Sep 2020, at 3:20, Michal Hocko wrote:

> On Fri 04-09-20 14:10:45, Roman Gushchin wrote:
>> On Fri, Sep 04, 2020 at 09:42:07AM +0200, Michal Hocko wrote:
> [...]
>>> An explicit opt-in sounds much more appropriate to me as well. If we =
go
>>> with a specific API then I would not make it 1GB pages specific. Why
>>> cannot we have an explicit interface to "defragment" address space
>>> range into large pages and the kernel would use large pages where
>>> appropriate? Or is the additional copying prohibitively expensive?
>>
>> Can you, please, elaborate a bit more here? It seems like madvise(MADV=
_HUGEPAGE)
>> provides something similar to what you're describing, but there are lo=
t
>> of details here, so I'm probably missing something.
>
> MADV_HUGEPAGE is controlling a preference for THP to be used for a
> particular address range. So it looks similar but the historical
> behavior is to control page faults as well and the behavior depends on
> the global setup.
>
> I've had in mind something much simpler. Effectively an API to invoke
> khugepaged (like) functionality synchronously from the calling context
> on the specific address range. It could be more aggressive than the
> regular khugepaged and create even 1G pages (or as large THPs as page
> tables can handle on the particular arch for that matter).
>
> As this would be an explicit call we do not have to be worried about
> the resulting latency because it would be an explicit call by the
> userspace.  The default khugepaged has a harder position there because
> has no understanding of the target address space and cannot make any
> cost/benefit evaluation so it has to be more conservative.

Something like MADV_HUGEPAGE_SYNC? It would be useful, since users have
better and clearer control of getting huge pages from the kernel and
know when they will pay the cost of getting the huge pages.

I would think the suggestion is more about the huge page control options
currently provided by the kernel do not have predictable performance
outcome, since MADV_HUGEPAGE is a best-effort option and does not tell
users whether the marked virtual address range is backed by huge pages
or not when the madvise returns. MADV_HUGEPAGE_SYNC would provide a
deterministic result to users on whether the huge page(s) are formed
or not.

=E2=80=94
Best Regards,
Yan Zi

--=_MailMate_7EDFBC1A-C6C8-4AEF-8110-676C99F27B91_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl9XnqUPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKS+oQAJojTqyoQvL31XcZ+NFpnvN4yzKKUCnvHJXH
z7mb9aqUbdDJ3sABiHPa8jyjZoyxbSh8khEyUtfuLgqQ3V8/rFNDcXbTgjKgu7dg
PUS9EdMATXRPkfRHe/X+3gXfmbsm1zD3qU84qQLPcenu3RAbWziXlC3+grWBqaVV
ktZ8NGtpLkzkx2Fk3s/ZBSe9HgCE8CJHBZtxGT6XXxMxaHbGNCu9jmtaRNVG1Fcu
QTMWe5eYbkR4g1hPmaPD9W5cjgEeno77VhdGH7RTCiOO18Yh5/4PUybz13qjztbY
1tCOfaZpYI1w9fVtlY8d0oPLytZ/A9YoCEz4NGhM6YmsHDR15Mjf8p7xPmfSK7cM
kRcIGabPHa6UDrzBgCjjnJHm3DIgO+56ZtS4smFbKG0+2nk5g43MSTrN07MrsAi7
d9GBp/qct3LCHWejJyxGKAJ9hPTVILJlIrp8pCajwPRvxXz/Kx0g61/nx571kr9H
VqV4UiF6xZGSYAiAsL66DqerxaIYn/y1wMyS/4GcCr37hb94T+KWh6DyV0oczQsb
NKbo4Kx+4LSpFgs4j7/h6ZEVu83u5uaFLuW832WDgi0KfZf/tGFzyjt1S0IXxzrA
wyP3WsaMRtOWl+66+nE7sEwY7fReeRY5fQnQ8KBtAsm/8v0hXMk5gmKQlLwbAK+n
LKsetGJu
=NLLe
-----END PGP SIGNATURE-----

--=_MailMate_7EDFBC1A-C6C8-4AEF-8110-676C99F27B91_=--