Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200908152221.082184905@linuxfoundation.org> <20200908152222.792503974@linuxfoundation.org>
 <20200908194723.GB6758@duo.ucw.cz>
In-Reply-To: <20200908194723.GB6758@duo.ucw.cz>
From:   Edwin Peer <edwin.peer@broadcom.com>
Date:   Tue, 8 Sep 2020 13:49:20 -0700
Message-ID: <CAKOOJTzmLvd15tbRd+hzkWnmU3MyWyLTuOoB8-x9j7RLC51KfA@mail.gmail.com>
Subject: Re: [PATCH 4.19 34/88] bnxt_en: fix HWRM error when querying VF temperature
To:     Pavel Machek <pavel@denx.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org, Marc Smith <msmith626@gmail.com>,
        Michael Chan <michael.chan@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Sasha Levin <sashal@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Sep 8, 2020 at 12:47 PM Pavel Machek <pavel@denx.de> wrote:

> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> > @@ -6836,16 +6836,19 @@ static ssize_t bnxt_show_temp(struct device *dev,
> ...
> > -     return sprintf(buf, "%u\n", temp);
> > +     if (len)
> > +             return len;
> > +
> > +     return sprintf(buf, "unknown\n");
> >  }
>
> We normally just do return -EIO (or other error code) in such cases.

That does seem more appropriate. I will fix it, thank you.

Regards,
Edwin Peer