Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4275400pxk; Tue, 8 Sep 2020 15:46:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwos46TCgiUXB8UXBWqd2sgkhqGOAN9FlleKkCH7aN1SHvZFZmB+GJ8zHJAsS1pKg6A5Dtk X-Received: by 2002:a50:aa94:: with SMTP id q20mr1249617edc.119.1599605207630; Tue, 08 Sep 2020 15:46:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599605207; cv=none; d=google.com; s=arc-20160816; b=mPftstmxHYyM0xmFJFN5Xmb8v8s/to5qc5wA2abXHFmyeCCnDDTrvjFX3KIvgo663U LKFZ79sC8bB2QsIPrcrOO7gcKVmr3vKBjvpdeTDQuPspKMxxwEGgmUiYEKaArv0yoKtL i5+V+LHsguxzKOmRHG8kydQBZtA93dgKlVRRy73p3VvAIE/g3xOGpR3tvLhwRwrv3KN/ BvtWlar01HGAriZRhiAkBidpGV4zZuHjuTr5sn/HYDSBIBKixWQOu7lh2YxtM7kfWb7x Kt3QJLlvnpeJs4TTRPzCsB7D8Iy32T0njWMOGqpmVmBTppU8bl8TcZ5C+v3kA4Lq5BrI L6wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=z3/ictLAUjgwyR6p93PByXq4qxQ+4mmKUUiuuNtvitg=; b=ZptsJYrIhyuPCmhx71SAM2G/h7GilpvTTdC2yy8pB8IPeAFPnCVpbIrsgQ4vgeRy2v gqaY7Dg6N6xiMoiDtzUapOc/qRtzu6tE6UL7ZJa+8ayek+LnhYgflwnKAuOAIkeDN+fH jsdl1inpioFBoO5i+mRI8TeUZ6tfXOLriuj/lz+d5B1GOmW/KdMknUQg5gGWIz/sX2c2 hEW2crVqIjNdrBtiLvsYMc0suOJ+4ltfVOcSg56VU0cQEzmiJ5fzDeRPeXaRf+euVISe NIxh5jFmsCDDoOY1bbddgVkBOFffOmsNG+X6vQQ1pN11/NRB3qz/jhwK0jPLGVTrfvLJ 3GfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RVSwExZb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q3si299868edg.429.2020.09.08.15.46.25; Tue, 08 Sep 2020 15:46:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RVSwExZb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730204AbgIHWo5 (ORCPT + 99 others); Tue, 8 Sep 2020 18:44:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729692AbgIHWkb (ORCPT ); Tue, 8 Sep 2020 18:40:31 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 563E6C0613ED; Tue, 8 Sep 2020 15:40:30 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id v23so1013193ljd.1; Tue, 08 Sep 2020 15:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z3/ictLAUjgwyR6p93PByXq4qxQ+4mmKUUiuuNtvitg=; b=RVSwExZb5g6VGMN9jgLaaogOEs+SCmeYNMrbZLzFudt2+fgEJqRTD7+wjFNAjq+GSX DwS/ekeO264iQikprxouo/pWuNzTHnkPbLYBdWpmTnN0Aa2BY7o+WcRQiFipn5Aw+DNX NDqM3mMND+Buiy12iflTp/qgNTITGaH/OZXYG6JLprr8VUJZriw2Uy58Lbn9yu1vVF6x VCKibYqgcHsRdzOVaB2M5uwYbIZHgPvR5c2wIOowrv+r8/nHvVJsFcnmjPTwUbcXRIfS UqypX13SBZEe0p4sXg+/SYGs2ta+aeK4YiyzXQEkGBwBzCPaFQ4C64wRic/Djg4RTiWI h0Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z3/ictLAUjgwyR6p93PByXq4qxQ+4mmKUUiuuNtvitg=; b=INohu18XCPVa6Lg+kK7OxQtTgwoJaHrPiqpchcTSjUTDmtsY0frFw7FYydDtArEtMz OhLd25hgPAuWxefX5U0cWTFNThxEJf04oa/xC14lMuzi+aKH4bOUUAFd64goSLf0Srm9 doOYaiXsF20aUTse3BnwzktsRqPMkA4FaniGJ0wOQBmerLR+KohUfXJje1zzNR6rKo/A ILT/CGufnB0qVPVeh3ln/aiPoRlBD9Lqt4dqg5Hp9WCmSkSLP+IGJ5AMxIG99AkSvDyu XpqY6KCXW6kiHSM+lAXHD/EQNgerYPS9DgCuIKQy6QkvXHudARWpObP0q7SVBN8njdib zBTw== X-Gm-Message-State: AOAM531/i53HO3E6qROYENGX9mrHmn0bElYGZUCGyzHt0FIeAnVZEPku eL5KkWJ9ROns2/OdmCyJUhM= X-Received: by 2002:a2e:7c09:: with SMTP id x9mr339432ljc.192.1599604828752; Tue, 08 Sep 2020 15:40:28 -0700 (PDT) Received: from localhost.localdomain (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.gmail.com with ESMTPSA id s15sm268311ljp.25.2020.09.08.15.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 15:40:28 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Andy Shevchenko Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 06/34] i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member Date: Wed, 9 Sep 2020 01:39:38 +0300 Message-Id: <20200908224006.25636-7-digetx@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200908224006.25636-1-digetx@gmail.com> References: <20200908224006.25636-1-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "non_hs_mode" divisor value is fixed, thus there is no need to have the variable i2c_dev.clk_divisor_non_hs_mode struct member. Let's remove it and move the mode selection into tegra_i2c_init() where it can be united with the timing selection. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 46 ++++++++++++++++------------------ 1 file changed, 21 insertions(+), 25 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 720a75439e91..85ed0e02d48c 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -250,7 +250,6 @@ struct tegra_i2c_hw_feature { * @msg_buf_remaining: size of unsent data in the message buffer * @msg_read: identifies read transfers * @bus_clk_rate: current I2C bus clock rate - * @clk_divisor_non_hs_mode: clock divider for non-high-speed modes * @is_multimaster_mode: track if I2C controller is in multi-master mode * @tx_dma_chan: DMA transmit channel * @rx_dma_chan: DMA receive channel @@ -281,7 +280,6 @@ struct tegra_i2c_dev { size_t msg_buf_remaining; int msg_read; u32 bus_clk_rate; - u16 clk_divisor_non_hs_mode; bool is_multimaster_mode; struct dma_chan *tx_dma_chan; struct dma_chan *rx_dma_chan; @@ -783,6 +781,7 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev) u32 val; int err; u32 clk_divisor, clk_multiplier; + u32 non_hs_mode; u32 tsu_thd; u8 tlow, thigh; @@ -805,24 +804,33 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev) if (i2c_dev->is_vi) tegra_i2c_vi_init(i2c_dev); - /* Make sure clock divisor programmed correctly */ - clk_divisor = FIELD_PREP(I2C_CLK_DIVISOR_HSMODE, - i2c_dev->hw->clk_divisor_hs_mode) | - FIELD_PREP(I2C_CLK_DIVISOR_STD_FAST_MODE, - i2c_dev->clk_divisor_non_hs_mode); - i2c_writel(i2c_dev, clk_divisor, I2C_CLK_DIVISOR); - - if (i2c_dev->bus_clk_rate > I2C_MAX_STANDARD_MODE_FREQ && - i2c_dev->bus_clk_rate <= I2C_MAX_FAST_MODE_PLUS_FREQ) { + switch (i2c_dev->bus_clk_rate) { + case I2C_MAX_STANDARD_MODE_FREQ + 1 ... I2C_MAX_FAST_MODE_PLUS_FREQ: + default: tlow = i2c_dev->hw->tlow_fast_fastplus_mode; thigh = i2c_dev->hw->thigh_fast_fastplus_mode; tsu_thd = i2c_dev->hw->setup_hold_time_fast_fast_plus_mode; - } else { + + if (i2c_dev->bus_clk_rate > I2C_MAX_FAST_MODE_FREQ) + non_hs_mode = i2c_dev->hw->clk_divisor_fast_plus_mode; + else + non_hs_mode = i2c_dev->hw->clk_divisor_fast_mode; + break; + + case 0 ... I2C_MAX_STANDARD_MODE_FREQ: tlow = i2c_dev->hw->tlow_std_mode; thigh = i2c_dev->hw->thigh_std_mode; tsu_thd = i2c_dev->hw->setup_hold_time_std_mode; + non_hs_mode = i2c_dev->hw->clk_divisor_std_mode; + break; } + /* Make sure clock divisor programmed correctly */ + clk_divisor = FIELD_PREP(I2C_CLK_DIVISOR_HSMODE, + i2c_dev->hw->clk_divisor_hs_mode) | + FIELD_PREP(I2C_CLK_DIVISOR_STD_FAST_MODE, non_hs_mode); + i2c_writel(i2c_dev, clk_divisor, I2C_CLK_DIVISOR); + if (i2c_dev->hw->has_interface_timing_reg) { val = FIELD_PREP(I2C_INTERFACE_TIMING_THIGH, thigh) | FIELD_PREP(I2C_INTERFACE_TIMING_TLOW, tlow); @@ -837,7 +845,7 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev) i2c_writel(i2c_dev, tsu_thd, I2C_INTERFACE_TIMING_1); clk_multiplier = tlow + thigh + 2; - clk_multiplier *= i2c_dev->clk_divisor_non_hs_mode + 1; + clk_multiplier *= non_hs_mode + 1; err = clk_set_rate(i2c_dev->div_clk, i2c_dev->bus_clk_rate * clk_multiplier); @@ -1751,18 +1759,6 @@ static int tegra_i2c_probe(struct platform_device *pdev) goto unprepare_fast_clk; } - if (i2c_dev->bus_clk_rate > I2C_MAX_FAST_MODE_FREQ && - i2c_dev->bus_clk_rate <= I2C_MAX_FAST_MODE_PLUS_FREQ) - i2c_dev->clk_divisor_non_hs_mode = - i2c_dev->hw->clk_divisor_fast_plus_mode; - else if (i2c_dev->bus_clk_rate > I2C_MAX_STANDARD_MODE_FREQ && - i2c_dev->bus_clk_rate <= I2C_MAX_FAST_MODE_FREQ) - i2c_dev->clk_divisor_non_hs_mode = - i2c_dev->hw->clk_divisor_fast_mode; - else - i2c_dev->clk_divisor_non_hs_mode = - i2c_dev->hw->clk_divisor_std_mode; - ret = clk_prepare(i2c_dev->div_clk); if (ret < 0) { dev_err(i2c_dev->dev, "Clock prepare failed %d\n", ret); -- 2.27.0