Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4324999pxk; Tue, 8 Sep 2020 17:31:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFb/IeK5tEMXDR/+Wt7vCAYT1AmVFbJTtQuBzs0UlGFxDugMPn7N7KmqK5fSxmd898fy8N X-Received: by 2002:a50:9355:: with SMTP id n21mr1540095eda.237.1599611459992; Tue, 08 Sep 2020 17:30:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599611459; cv=none; d=google.com; s=arc-20160816; b=XRwMWmLbcYg4VM6w9WiJR01XJlcONW0dcr/2m8ddoNocAMNvcMenp8Vp2OruaOHsX2 r35xL0AV6LOr1z9KhU2l4i6bnoth7SlJ0C20UkLNrX5hFDJm5kUdU+5RssWeDxXEndIW mIl0h3OSY8mdxY5VpPX5e6/ajRYOC6z4ksQ6N/ObcRGRcNEXQlVBGfl9x45OOlOE8QKt 9w7eRwWnMR6IZNkkU+1Ko+Z/AA6wFR9qcQbmH6ff0mk+UOzoMLUObIDGhaM9+9NSQqgC nLykioDWPJu2MLq+e3aq2Cx2msJfbL0zBIwXj3tVLfLBKbeDCIUsSStBi77uFiq9odsz 38eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hdBlMjlvaNPT6QE+SDEJjGI84mLc8yqhLG+5WR79dvM=; b=AS8lvKNKrAx5UUHsCRm94GNiiNrPX3pY+x6OdNI0ezvXLsVI2C6q++NgZqxx5naVNs A6YirrZthp9KNZKJj6Y5B5x7BCIRBS1lFcHB1p16O2APZ8Csg457gSgEjem7r0WIgT/v TsLqUm3Xhj/2KIvBhHYXx8hjNJ054rmLSBEq4KkG42V4Jcl7yBSt2kDH250OWzkLgUTR g8e3/nCV6CRIJ7rfwXHnmA8TrbzbOhCoA5yZa4gXBmskNsRpFiZwaRgwim/dFCJGnQCq mDop1Kf4dJt6h3W2J9LM/wMyV5qeOJ3l+AjMYOJnsdvRkH/eoh1Wxo4bP8b44QopQPqp KMUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fzFmi5nK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si370432ejg.212.2020.09.08.17.30.35; Tue, 08 Sep 2020 17:30:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fzFmi5nK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbgIIA1y (ORCPT + 99 others); Tue, 8 Sep 2020 20:27:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:47384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726560AbgIIA1x (ORCPT ); Tue, 8 Sep 2020 20:27:53 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1AF832145D; Wed, 9 Sep 2020 00:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599611273; bh=2LZCwU8UpJcj0ae9NmaJz2EpwentD/rjiwDLn66U+d4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fzFmi5nKxcXnvPQpdMiRMsZ5EEaKi1c4xG2aQwynZF/kqI2uMGDUsLJUPbzaideC8 CSoGa8B/w4GjsQFMA7I6p3zdYxynLBi6W7c9xltXxow8QE8FbLLi+/2qTmcAEP+vrZ z7HtgLB/HwaCC4W3XXUSameRn9zzscy9yfx+VumY= Date: Tue, 8 Sep 2020 17:27:51 -0700 From: Jakub Kicinski To: nikolay@cumulusnetworks.com Cc: davem@davemloft.net, netdev@vger.kernel.org, paulmck@kernel.org, joel@joelfernandes.org, josh@joshtriplett.org, peterz@infradead.org, christian.brauner@ubuntu.com, rcu@vger.kernel.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, roopa@nvidia.com Subject: Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition Message-ID: <20200908172751.4da35d60@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <5ABC15D5-3709-4CA4-A747-6A7812BB12DD@cumulusnetworks.com> References: <20200908090049.7e528e7f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200908173624.160024-1-kuba@kernel.org> <5ABC15D5-3709-4CA4-A747-6A7812BB12DD@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 08 Sep 2020 21:15:56 +0300 nikolay@cumulusnetworks.com wrote: > Ah, you want to solve it for all. :) > Looks and sounds good to me, > Reviewed-by: Nikolay Aleksandrov Actually, I give up, lockdep_is_held() is not defined without CONFIG_LOCKDEP, let's just go with your patch..