Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4370009pxk; Tue, 8 Sep 2020 19:13:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxklJBQqIBUpezbCDuUi5104/WB2Wg6D5KARPZY7jukRgBQ4sz9hsQFwojGAG5JHmKZZknv X-Received: by 2002:a17:906:1e51:: with SMTP id i17mr1431645ejj.103.1599617589961; Tue, 08 Sep 2020 19:13:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599617589; cv=none; d=google.com; s=arc-20160816; b=Xebua/kp5jEpCUvvwa/rRMOrfqargZskiYb0VGkzRaVgwnAQfZVlWzMzgTTFV8YQYG 5CRCsSDIL30hey4y4KUN8eSOhcdLrrQMUlCQIcepuNI59NwRFNgT2yoz4ygu+itD3yri sld70NNAYKaPGFHqlF5wYiRYLRDmTg9pVWeGeat+9QSEOBTb2LYKg29jh7eEwdQhhYBn PlYu0ruxQJCYZG6j/9VJV1bBKfNu+ensdzCLLmxjnPSndl9iK6XFfA3YsjFruxkX4u1y BfVb10yU49zXc+wbYw2nE6Sotwaf0NXIWAKTLvUI3me+MofcAXs94CeePQDWrWOU+Qr+ YD1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RA5KU7hC/4RZDaVvqLweitGeGaEEcpxcs09QIiSSOKw=; b=PK7kYqnh5MwF2OsxTBeEeJ4MiSYCGOopM4/M2eGM95GfVE5T4ucjy7E3e9ku7d004c s0mLIoQCoihd8rZArwTufB1gOJXxD/b2rqrD9OWwwV1/JHXsxB4qwN41eTVyaxh0P1kZ R97iXqET//vqqv57AImR6odCSo9yLQw5Gdurnu4yQtrUVE/EXJAk84Ahf/qfy/dKfcCN JLmZ11nsd2fCXZ5lnMnUTT0ePZkM4b3JDt+9fmvGmQEOdmvBnXVqhUexD347RDXXAeNv AwOVMHPEHJbySGSzpUBO6Lc4EzwRE+VUdKIF70M2+G8M0nX+g2Wqt6iNrfFgUK9i4Hmy ICEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=F99m21MS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pw7si537833ejb.409.2020.09.08.19.12.47; Tue, 08 Sep 2020 19:13:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=F99m21MS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728971AbgIICKh (ORCPT + 99 others); Tue, 8 Sep 2020 22:10:37 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:40324 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbgIICKe (ORCPT ); Tue, 8 Sep 2020 22:10:34 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08929wGo153585; Wed, 9 Sep 2020 02:10:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=RA5KU7hC/4RZDaVvqLweitGeGaEEcpxcs09QIiSSOKw=; b=F99m21MSZRInKB49TaY3cxp1Y/TaHGaKVfrbGNtQ+YsW31l0Q/RWvTH/7lL0HJpu40Yj W3cz2oT+ACPCxuzcLQ1ceculkcyw0ILVaWsvD0l20J/y6nzpQ8OqgMpw0G2PFMiaFosb cWiAVtgmAu64naqtxV2PWtZCV4apOY0ElKGL5nVE0l5f/X21ASHz5MTvf5RUlJw6XCuH qJxKDWL/M22Es+D1CRDy++x0hxO5HQbhtPqXMo7z5XGnIn8PEaQSfoUXRJnA7Iz4KrNZ B/c3tSZjbpX++XmwE2N0G+wNL+vDQYKz7n391nVwJ+M8npn7RYYXCD7lvrVGj8paFWiu /g== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 33c3amxttw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 09 Sep 2020 02:10:24 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08925Zu3069209; Wed, 9 Sep 2020 02:08:23 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 33dacjq2pf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Sep 2020 02:08:23 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08928LlD022247; Wed, 9 Sep 2020 02:08:21 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 08 Sep 2020 19:08:20 -0700 From: "Martin K. Petersen" To: Dan Carpenter , Dan Williams , "James E.J. Bottomley" Cc: "Martin K . Petersen" , John Garry , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, "Gustavo A. R. Silva" , kernel-janitors@vger.kernel.org, Jason Yan Subject: Re: [PATCH] scsi: libsas: Fix error path in sas_notify_lldd_dev_found() Date: Tue, 8 Sep 2020 22:08:19 -0400 Message-Id: <159961727333.18958.11850401583995372808.b4-ty@oracle.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200905125836.GF183976@mwanda> References: <20200905125836.GF183976@mwanda> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9738 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=781 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009090018 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9738 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=795 suspectscore=0 adultscore=0 mlxscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009090018 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Sep 2020 15:58:36 +0300, Dan Carpenter wrote: > In sas_notify_lldd_dev_found(), if we can't find a device, then it seems > like the wrong thing to mark the device as found and to increment the > reference count. None of the callers ever drop the reference in that > situation. Applied to 5.9/scsi-fixes, thanks! [1/1] scsi: libsas: Fix error path in sas_notify_lldd_dev_found() https://git.kernel.org/mkp/scsi/c/fdcb7900d9ab -- Martin K. Petersen Oracle Linux Engineering