Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp108268pxk; Tue, 8 Sep 2020 23:47:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrmGMD2yHr8EvZaU2ucuAvWNdhVJ7d+HGinvCQdpim4xaZrewaAGFULT3UbCCiqO5ImO+b X-Received: by 2002:a17:906:f92:: with SMTP id q18mr2102496ejj.237.1599634044899; Tue, 08 Sep 2020 23:47:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599634044; cv=none; d=google.com; s=arc-20160816; b=q7Mgf8fqTRtxrwT37kMtgjJU43rHkxj6GV7hTzAI9wE3uFN2ymYd3oLUOfW8ofc4x7 xeylhBABPX415XUMEvWpBMI0dEj824VM2p+ocTzwfhzdqWlqGsz+a4nOjytZ7iQXqTSZ 0SsB8dDnvDzXJkWnnYBNXyFDRb4aK8aL4MxihkO5i6BlJjoxoN411KHCd4RzUs2mbP2G tttxnHKgh5x1zgNaJFZfIc1xDA+vWWYLMlgr0drlgaah8wwP55d+1cgF1Epx9QS1QEaS gFff0Gg6ILW/KCzO4SkpHXZ53JbDvWqIR8yahO6CD0g4IAkJNY+0sS6NVT10mNM0KxE5 eu7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=oxIJ3ewq7940fgdVkK6VJO3fECGRTFj+rTuMRCH6HaI=; b=0BQfRA+VGYn0R1QfEVEJ8wT7JHY1L5okbnxhU35ReQaRapmt6134qPSEzi7PJ2n7Gh paOVKMwgOo5itkBXMDAnSKJ+01l4VEGbmgleJTds20ZEV4fv/svHr3+vIZ6lnjgJAM8D TC7y1MG9dthcG7/hB+FwEjiVWOq16KC5K8kHNVyUelgx1f8v5EUjJBoA6mxns/4STlRi D7GDNUJOgkc76zkDPCNmOvS2MOYjgbXrEKkuyxcA0WxNu76U7LWVeARj023unKkbvWEs ljwlVfrs5ARa8wTeZ5JYHapY6ZV2yXsJMn7/wuMi/WJ9z5YSQnwDn0wChkyAjhjtiwvL +8oA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i10si380878edb.37.2020.09.08.23.46.59; Tue, 08 Sep 2020 23:47:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725877AbgIIGpW (ORCPT + 99 others); Wed, 9 Sep 2020 02:45:22 -0400 Received: from mga12.intel.com ([192.55.52.136]:6193 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbgIIGpS (ORCPT ); Wed, 9 Sep 2020 02:45:18 -0400 IronPort-SDR: rgtbG2iJunMjh3+4mJbmG3tpCqHGEBFccqI54I+5dmgU1FjmWwHaVRe0RqzdY/z32Y/IcntPMm T6crA+qvFZvg== X-IronPort-AV: E=McAfee;i="6000,8403,9738"; a="137796876" X-IronPort-AV: E=Sophos;i="5.76,408,1592895600"; d="scan'208";a="137796876" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 23:45:18 -0700 IronPort-SDR: vpvCsOeJrcXHK+2ZLb/8FiQfDPV6+Xh7438/WGgZ7DOS2IESAIWFqo6sEuSTN8+NVVw1nnLJ5l GHr36XrXIDwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,408,1592895600"; d="scan'208";a="333724606" Received: from um.fi.intel.com (HELO um) ([10.237.72.57]) by orsmga008.jf.intel.com with ESMTP; 08 Sep 2020 23:45:15 -0700 From: Alexander Shishkin To: Shuah Khan , peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, jolsa@redhat.com, namhyung@kernel.org Cc: Shuah Khan , linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com Subject: Re: [PATCH] kernel: events: Use scnprintf() in show_pmu_*() instead of snprintf() In-Reply-To: <20200901234930.359126-1-skhan@linuxfoundation.org> References: <20200901234930.359126-1-skhan@linuxfoundation.org> Date: Wed, 09 Sep 2020 09:45:15 +0300 Message-ID: <87o8mfxxc4.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shuah Khan writes: > Since snprintf() returns would-be-output size instead of the actual > output size, replace it with scnprintf(), so the nr_addr_filters_show(), > type_show(), and perf_event_mux_interval_ms_show() routines return the > actual size. Well, firstly they should just be sprintf()s, and secondly, I wouldn't worry about it, because [0]. [0] https://marc.info/?l=linux-kernel&m=159874491103969&w=2 Regards, -- Alex