Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp117270pxk; Wed, 9 Sep 2020 00:08:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwq7xi6g1pSGLPsCBnguN3kxDR5qgnvmFf4P+fW+f1RM5j3MbCKK5IgLTefLCw3C79FruU/ X-Received: by 2002:a17:906:95d1:: with SMTP id n17mr2369156ejy.324.1599635319179; Wed, 09 Sep 2020 00:08:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599635319; cv=none; d=google.com; s=arc-20160816; b=M75HOFCg0IKMquN/HrvHfV0weEWZEXryne4b+kPdjDX9nmSSr1vgRs03JHQ0KLGaJ3 aZBvba+dcMW9DlBUJFHFFras93LTZBuXCTb7x6L4SR4Gz6mLQmmWlbOfgnD93NI57U+V ZOyoYDHixKVQV0LmZvENVJaBV8O8PCQEpqTj+aP8bLNqPMA++BAY2ECkHGj0XhGXuBuP NtjZCtW64EKK/VvHY0i4OAXbVi+s38L+/vRKDiGVzQDFiSee0zag27mlaE84tKUWFD03 KuQq446sXOrE0jXF46lPto1VlkNRMOTksAB2dEJaovyKAjlqCRxySxV7wVCJXsLaVDBC 0/6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=OisEO4jaSIfeERIhkIAL872QnJzJXCLXxgUqnKpDARE=; b=Ssmr195XdHveSUFd5xogyrNSzD+cI60D+PyHcIPwo9NdvY9sRmzfy3+2RQw0uPPF8w hfULikApslXOH5DMElxIJ9FXGVlnGLL1Bo9f0nGk/Gmt0C1MkyUfGAX3swzb8OGHriHr NlP8qowPrzGnVQ6DX9PGIkERBWmEz63zfl5e4/E9vj/wtM0+c983OWlDmV5JERM8Gyz5 MoWxvW147TSFEh6sogs7xPPgMkKMawClwlhQ97JR2HBP55Jje9nX4ZnHfR26bfoMUOtg XBhq6Pr8xasyS42w0bFuYZP2r8tOM46YP9KF5+Xlu16KBDsg+cHVNSJ03veBv4pWp4Ln DvaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=SrydzyYR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e21si942701eje.2.2020.09.09.00.08.16; Wed, 09 Sep 2020 00:08:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=SrydzyYR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726169AbgIIHF7 (ORCPT + 99 others); Wed, 9 Sep 2020 03:05:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725864AbgIIHFw (ORCPT ); Wed, 9 Sep 2020 03:05:52 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7934BC061573 for ; Wed, 9 Sep 2020 00:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OisEO4jaSIfeERIhkIAL872QnJzJXCLXxgUqnKpDARE=; b=SrydzyYRh+xGXT0KW6s048zloI 52J0q13JFWSZKNdGubmRKwYrmt1vcToWiUp8aPCggtl7svrazZbQDIYelaDpdcoplz1wyl2qx7M7B Ny83Jqaay5fvT5oDuSdx2jjPa2SHsHaAvOug4P6P1Lby6vNzYCSYsS/OnOn5H3AepNNLWrd8wIsq0 iRcT2Co0fVyMFXdJ4LNKzD+XKCfGgJdCylieR7oSDGdv6Tf0okYTkuvPlCHJzSr4Ma0YXqJR8DSUP 3reQwJMbCDIus+ocYSl3r0fwjMa1RRSzTNLzjunQipU4u6MbFbE2PkFYBQroexsWLKxzjM492lLgU wDNPOfCw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFuAm-0007pZ-Le; Wed, 09 Sep 2020 07:05:40 +0000 Date: Wed, 9 Sep 2020 08:05:40 +0100 From: Christoph Hellwig To: Lu Baolu Cc: Tom Murphy , iommu@lists.linux-foundation.org, Joerg Roedel , David Woodhouse , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/5] iommu: Add iommu_dma_free_cpu_cached_iovas function Message-ID: <20200909070540.GA28245@infradead.org> References: <20200903201839.7327-1-murphyt7@tcd.ie> <20200903201839.7327-3-murphyt7@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static inline void iommu_dma_free_cpu_cached_iovas(unsigned int cpu, > + struct iommu_domain > *domain) This adds a crazy long line. Which is rather pointless as other bits of code in the patch use the more compact two tab indentations for the prototype continuation lines anyway.