Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp129471pxk; Wed, 9 Sep 2020 00:34:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZXe4C+wRvkzQdzsnbDLBDi+JcBbx/5xZofad8JWUWd1GyFr4rn0JYYw9827K/HyKgEw8C X-Received: by 2002:a50:ab13:: with SMTP id s19mr2655604edc.357.1599636877068; Wed, 09 Sep 2020 00:34:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599636877; cv=none; d=google.com; s=arc-20160816; b=oxl0Ts2uVMC0IKDPShJxLIh1DXKi1sI0g6LmBxfViQqOUMN6cwR7pN0YYiCAjV1duk fhYB1XWWI17CYr7iGRsCapG8we3A6EzMuB0Gy7cNsjxyoXEXDaNwFa/H2gLsNhowpsz8 2FITODCqsao7QB7QP57MTTcB+2B64QO9sST/d9+cgwB51C01CBoh06rjYxGpIILDe/l3 FibL1aSqIuqK6kIgYTx3SMvIPb2BKlzLCqfeWAsKnQ8zNnfP+GLSM/oeO0QIKdT2j+Bq UAapIGEdOTo5WB3IivN9wK2DPrgSLFh0OVbGdmc5MjduZaCkg5YjB7HK305xbjteLY9d ejOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=vCq1jyl5janfctZVpJDqsF657XPIPNkUqvh3GDbbmx8=; b=olxzAlwStotBFF4Ku+sEq7BhMHoD1otQmrSoKm0sS2wO6+ux1i/D6Tp2Qbz6Ds38/R BqUbU4ozjtWb6arM/QaME3fwgmGbotEwiYjYexHQC5+VHI2cDe5Ict0S55umAbtASppr DFSbGyzChpBlN7WxMvF6oRBLpuMsKagjvJhIitNgZ/4AMndieV8K4nbmIvWYSCRhqV9m NVQQPD+pO7fQiSL2lvFrQiAO0lrRgdptv2BMOH5nAKyDLLYUFoETs0yxMmfZvNDI9leA rPc2tZwnEhoT5J9aCbCoyVXUfoNjLA4CPDgD54vWVjfBtQqe9VtZNbonD6+OCTzf7BsL um6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="0++a0Y/L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si1047148ejx.326.2020.09.09.00.34.14; Wed, 09 Sep 2020 00:34:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="0++a0Y/L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbgIIHbk (ORCPT + 99 others); Wed, 9 Sep 2020 03:31:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726708AbgIIHbj (ORCPT ); Wed, 9 Sep 2020 03:31:39 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D52B1C061755 for ; Wed, 9 Sep 2020 00:31:38 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id c18so1744228wrm.9 for ; Wed, 09 Sep 2020 00:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:organization:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vCq1jyl5janfctZVpJDqsF657XPIPNkUqvh3GDbbmx8=; b=0++a0Y/L/izMf3R9qjeVxrMDFYim16SBvgHmVqoPOrm2np2TtmSv0F1UCwX3USVsYG kA5jW53FW2GeAsQQbfCgdVjb5Oc6Pza84e/ATyUvwacpI10isbkJYx4RqKssnyMl1/+D eSKr7ZJ54SylBEwpWQ+BEMtTizFoRCYIJ+nEsw7yokdYfjQVIDawydMXLE97mCnxxilQ ETxK0jHp3zskOIPRJGiqXv+9c/WUeYr1zJoSZ0Sx0dJ4I7lExDSWfyNTJnJljm0kF/9q ZH2BuTKDqXkNl6gWPeuyWEx6Mr/zSQhqLRDoJNw9Oz57vJ/+UBNHBDxwhFECqbKTjIPK H+Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vCq1jyl5janfctZVpJDqsF657XPIPNkUqvh3GDbbmx8=; b=QZYYDN8593BjqJRNFcInb1WF9Y/07E4+TeZav/fqEePdXbu30JZ1yzMQXmKHLQkiMN jEk9OmMSHewARGRZsVQv5e+qQdI+tRFKFP0/tusNmrDqpSZHIDCfzMU5Z3m36WFJNi5o 6IqqF0oIvPPnJZHNE7V6wB8dfn+DExClIgqxGak87nd+ua6pv8m+/mH+D/TmDCXq2YZ3 DF8FpIgvPtudqon1obI+cpEXcKjXtlPE/KgJCfgGdNWgU62RatMjNjMRMtnALNjj80im Qupw1v9QNi2LJDNyUR1N2oVMfnHE6eE9ekS6ZUI+cucrV3P1fDPQYQdEkhaHwoo/JeBg VsgQ== X-Gm-Message-State: AOAM530dyA0ZH+tqXFJ/am9Li4G8A8wUggrvnSPjv7S2Q+kg2wZ/e3lK 7ZKpR+xinO0zpRmx3zbEFINKtssG5WTdQW9Z X-Received: by 2002:a5d:684b:: with SMTP id o11mr2518160wrw.101.1599636696900; Wed, 09 Sep 2020 00:31:36 -0700 (PDT) Received: from ?IPv6:2a01:e35:2ec0:82b0:5405:9623:e2f1:b2ac? ([2a01:e35:2ec0:82b0:5405:9623:e2f1:b2ac]) by smtp.gmail.com with ESMTPSA id g186sm2642446wmg.25.2020.09.09.00.31.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2020 00:31:36 -0700 (PDT) Subject: Re: [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute To: Rob Herring Cc: kishon@ti.com, repk@triplefau.lt, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200907073402.26674-1-narmstrong@baylibre.com> <20200907073402.26674-2-narmstrong@baylibre.com> <20200908195003.GB790974@bogus> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwU0EVid/pAEQAND7AFhr 5faf/EhDP9FSgYd/zgmb7JOpFPje3uw7jz9wFb28Cf0Y3CcncdElYoBNbRlesKvjQRL8mozV 9RN+IUMHdUx1akR/A4BPXNdL7StfzKWOCxZHVS+rIQ/fE3Qz/jRmT6t2ZkpplLxVBpdu95qJ YwSZjuwFXdC+A7MHtQXYi3UfCgKiflj4+/ITcKC6EF32KrmIRqamQwiRsDcUUKlAUjkCLcHL CQvNsDdm2cxdHxC32AVm3Je8VCsH7/qEPMQ+cEZk47HOR3+Ihfn1LEG5LfwsyWE8/JxsU2a1 q44LQM2lcK/0AKAL20XDd7ERH/FCBKkNVzi+svYJpyvCZCnWT0TRb72mT+XxLWNwfHTeGALE +1As4jIS72IglvbtONxc2OIid3tR5rX3k2V0iud0P7Hnz/JTdfvSpVj55ZurOl2XAXUpGbq5 XRk5CESFuLQV8oqCxgWAEgFyEapI4GwJsvfl/2Er8kLoucYO1Id4mz6N33+omPhaoXfHyLSy dxD+CzNJqN2GdavGtobdvv/2V0wukqj86iKF8toLG2/Fia3DxMaGUxqI7GMOuiGZjXPt/et/ qeOySghdQ7Sdpu6fWc8CJXV2mOV6DrSzc6ZVB4SmvdoruBHWWOR6YnMz01ShFE49pPucyU1h Av4jC62El3pdCrDOnWNFMYbbon3vABEBAAHCwn4EGAECAAkFAlYnf6QCGwICKQkQFpq3saTP +K7BXSAEGQECAAYFAlYnf6QACgkQd9zb2sjISdGToxAAkOjSfGxp0ulgHboUAtmxaU3viucV e2Hl1BVDtKSKmbIVZmEUvx9D06IijFaEzqtKD34LXD6fjl4HIyDZvwfeaZCbJbO10j3k7FJE QrBtpdVqkJxme/nYlGOVzcOiKIepNkwvnHVnuVDVPcXyj2wqtsU7VZDDX41z3X4xTQwY3SO1 9nRO+f+i4RmtJcITgregMa2PcB0LvrjJlWroI+KAKCzoTHzSTpCXMJ1U/dEqyc87bFBdc+DI k8mWkPxsccdbs4t+hH0NoE3Kal9xtAl56RCtO/KgBLAQ5M8oToJVatxAjO1SnRYVN1EaAwrR xkHdd97qw6nbg9BMcAoa2NMc0/9MeiaQfbgW6b0reIz/haHhXZ6oYSCl15Knkr4t1o3I2Bqr Mw623gdiTzotgtId8VfLB2Vsatj35OqIn5lVbi2ua6I0gkI6S7xJhqeyrfhDNgzTHdQVHB9/ 7jnM0ERXNy1Ket6aDWZWCvM59dTyu37g3VvYzGis8XzrX1oLBU/tTXqo1IFqqIAmvh7lI0Se gCrXz7UanxCwUbQBFjzGn6pooEHJYRLuVGLdBuoApl/I4dLqCZij2AGa4CFzrn9W0cwm3HCO lR43gFyz0dSkMwNUd195FrvfAz7Bjmmi19DnORKnQmlvGe/9xEEfr5zjey1N9+mt3//geDP6 clwKBkq0JggA+RTEAELzkgPYKJ3NutoStUAKZGiLOFMpHY6KpItbbHjF2ZKIU1whaRYkHpB2 uLQXOzZ0d7x60PUdhqG3VmFnzXSztA4vsnDKk7x2xw0pMSTKhMafpxaPQJf494/jGnwBHyi3 h3QGG1RjfhQ/OMTX/HKtAUB2ct3Q8/jBfF0hS5GzT6dYtj0Ci7+8LUsB2VoayhNXMnaBfh+Q pAhaFfRZWTjUFIV4MpDdFDame7PB50s73gF/pfQbjw5Wxtes/0FnqydfId95s+eej+17ldGp lMv1ok7K0H/WJSdr7UwDAHEYU++p4RRTJP6DHWXcByVlpNQ4SSAiivmWiwOt490+Ac7ATQRN WQbPAQgAvIoM384ZRFocFXPCOBir5m2J+96R2tI2XxMgMfyDXGJwFilBNs+fpttJlt2995A8 0JwPj8SFdm6FBcxygmxBBCc7i/BVQuY8aC0Z/w9Vzt3Eo561r6pSHr5JGHe8hwBQUcNPd/9l 2ynP57YTSE9XaGJK8gIuTXWo7pzIkTXfN40Wh5jeCCspj4jNsWiYhljjIbrEj300g8RUT2U0 FcEoiV7AjJWWQ5pi8lZJX6nmB0lc69Jw03V6mblgeZ/1oTZmOepkagwy2zLDXxihf0GowUif GphBDeP8elWBNK+ajl5rmpAMNRoKxpN/xR4NzBg62AjyIvigdywa1RehSTfccQARAQABwsBf BBgBAgAJBQJNWQbPAhsMAAoJEBaat7Gkz/iuteIH+wZuRDqK0ysAh+czshtG6JJlLW6eXJJR Vi7dIPpgFic2LcbkSlvB8E25Pcfz/+tW+04Urg4PxxFiTFdFCZO+prfd4Mge7/OvUcwoSub7 ZIPo8726ZF5/xXzajahoIu9/hZ4iywWPAHRvprXaim5E/vKjcTeBMJIqZtS4u/UK3EpAX59R XVxVpM8zJPbk535ELUr6I5HQXnihQm8l6rt9TNuf8p2WEDxc8bPAZHLjNyw9a/CdeB97m2Tr zR8QplXA5kogS4kLe/7/JmlDMO8Zgm9vKLHSUeesLOrjdZ59EcjldNNBszRZQgEhwaarfz46 BSwxi7g3Mu7u5kUByanqHyA= Organization: Baylibre Message-ID: Date: Wed, 9 Sep 2020 09:31:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200908195003.GB790974@bogus> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/09/2020 21:50, Rob Herring wrote: > On Mon, Sep 07, 2020 at 09:34:00AM +0200, Neil Armstrong wrote: >> The Amlogic AXG MIPI + PCIe Analog PHY should be a subnode of the hhi mfd >> node like the axg-clkc node. >> >> Thus the reg attribute is not needed. > > If the phy registers have an address then it should remain even if Linux > happens to not care. The exception is if the registers are all > interleaved with other stuff. This is not really a question about linux using it or not. The PHY registers happens to be at the beginning of a large zone containing interleaved system registers (mainly clocks, power management, PHY control..). The goal is to model it the same way as the other "features" of this zone, like Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt and Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml and have a coherent bindings scheme. Neil > >> >> Signed-off-by: Neil Armstrong >> --- >> .../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml >> index 18c1ec5e19ad..a9040aa387cf 100644 >> --- a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml >> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml >> @@ -13,15 +13,11 @@ properties: >> compatible: >> const: amlogic,axg-mipi-pcie-analog-phy >> >> - reg: >> - maxItems: 1 >> - >> "#phy-cells": >> const: 1 >> >> required: >> - compatible >> - - reg >> - "#phy-cells" >> >> additionalProperties: false >> -- >> 2.22.0 >>