Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1599620043-12908-1-git-send-email-wanpengli@tencent.com> <87h7s7mk93.fsf@vitty.brq.redhat.com>
In-Reply-To: <87h7s7mk93.fsf@vitty.brq.redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Wed, 9 Sep 2020 16:38:37 +0800
Message-ID: <CANRm+CxLpGaC66TVUftrxXdfBg+CHJzDMKh4mFvdpm-HTK0QwA@mail.gmail.com>
Subject: Re: [PATCH 1/3] KVM: SVM: Get rid of handle_fastpath_set_msr_irqoff()
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Paul K ." <kronenpj@kronenpj.dyndns.org>,
        "# v3 . 10+" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 9 Sep 2020 at 16:23, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
> Wanpeng Li <kernellwp@gmail.com> writes:
>
> > From: Wanpeng Li <wanpengli@tencent.com>
> >
> > Analysis from Sean:
> >
> >  | svm->next_rip is reset in svm_vcpu_run() only after calling
> >  | svm_exit_handlers_fastpath(), which will cause SVM's
> >  | skip_emulated_instruction() to write a stale RIP.
> >
>
> This should only happen when svm->vmcb->control.next_rip is not set by
> hardware as skip_emulated_instruction() itself sets 'svm->next_rip'
> otherwise, right?

The bug is reported here
https://bugzilla.kernel.org/show_bug.cgi?id=209155 , the old machine
which the reporter uses doesn't have NRIP save on #VMEXIT support. :)

    Wanpeng